[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/14] Arm/alternative: hide casting away of const


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Wed, 2 Sep 2026 13:47:41 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yj0snSe6erq9pFcsQNTsOsWW4pZ2V4+nXZnGyipvatc=; b=kAEUoNbGdVXEYAKtBWELWA6jNQ2H4v/Px5Kc3rz4wGoTi1pZmuVZQ/TOmKqAu/zqqCOJ71m0XMrrxuCnOct0JBprW8TO/wvBQGU3Uwy4v0R2eDgaXsGpL7Sk+qdP4x7dLDWv3+9gwbr8+GAgGkE40jFYCGAbKNXDa206nVr6LfV5nbyhU3X25dEV7RFx32fFMjSUtMGFIiw3EyWpsHOaoKlpDsU3IuOtKxZjLb7WMuoC0MZ7V9pByq4gG0mTWsO2eEHUdZ5ghGfopMEv299PldBPpQpPZ4zYH9VGwk7zVN70ZamyaLddVgEkfYV+6XmQ5GUgHvgGw79V7UrbhVsWaQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vy7f98JuLC0MWazR3/XgjLzjPreqyu5j+Mjx0t56d0YcfcePM2kspj6b9hclQz+R6SMwn5o/CVbXAbVvAPi2xJE4MECZcKsL09Xk/6kvp+tztcivM2Hmy1ojwdX5/q+3XzIDxryBwEtnDkBkkAdYk+PrgNMHCaMwvSAXdKmEtRNwadFHM78d/v140Hz1voVunYNjm84XR4Gf78PnoMJmiYcPZs2w/+H/VPqL6gvg5NgJ6JTw7R+rz/MghzZztt46+w4CLUpe/Q61Zuudwk6y4XurnQ3CeofXcr46tXUD1k21TDEbkRvUReYXtMqhXefBNtwc0VmSTY19huOoNmFCCA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • Delivery-date: Wed, 02 Sep 2026 11:47:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 02-Sep-26 08:32, Jan Beulich wrote:
> We want to patch the original call site, which memory-wise is unrelated
> to the struct alt_instr * that we start from.
> 
> No functional change intended.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/arm/alternative.c
> +++ b/xen/arch/arm/alternative.c
> @@ -134,7 +134,7 @@ static int __apply_alternatives(const st
>              BUG_ON(alt->repl_len != alt->orig_len);
>  
>          origptr = ALT_ORIG_PTR(alt);
> -        updptr = (void *)origptr + update_offset;
> +        updptr = (void *)(long)origptr + update_offset;
NIT: Why long and not unsigned long like other places in this file?

Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.