[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 02/20] xen/dom0less: turn max_init_domid into a common variable
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 1 Sep 2026 09:14:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OoN2vw3UDsC1Lz/MWTRdE/XcswW4onF/0rl1nUHfALM=; b=Pp1WknXrKAAbC8S8MSTWeJ9IGOTl5/mzXUx/eNhoNqFMhBuSE7wUxyWiEhXHlxbN+eDoSHZAAyHq8sKD+u3UXKNmocjbXl7vQo3uUhVi9cQiDoWrAb8XCIuUJ1XFs/hsh1rpcqeZWGK/Y1TlA8pNnW9acpj1YpBPtu5JptNZZ9MObnWPRog/pdEzu5/KjqWBzJtYGPDN735exvPSfkDumlczTuvaTYFIOxUaxXjfbMu38BuNLorxhGEg0beBICVyj874WsGvYhJPDvMyK5jVDA15aFik5To2FjVJzMrUlkPdqTBnrAI1EU8Yb0xRcAVt0funC/wILBBEh55WX2gD4g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZQBNNJwKY7uCAI77/3/Tg1hO389FjLsDNsYGHVV1Jir69lQ8sOm5iBdQ/0AQO+olYpHJOtMZTc9ExZ2tQ7b2FPDx2vQZNDQPZihSHmm7huts5JRtDJGhzXxfQnADKAK38wxwcWy4ELiKbrcqUBXMBvdwIpp3e8JWqtvo2FxM2dHOsccASYI4JZBOQbSww9beFFPtRD/+z0sF34wLFtrcqF2dgiMEQcoArUQOSzFfyf5mJmqTT31XTSNQcnbzifDArSUUK1rqRQ666mVShGqJhOCpAzWcCc58W2emNGMFSKe7Cz51CBAvFwTh6I2+kcJGeOW9RUMJUfIz4MxJdYcbEQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>, Zheng Zhang <zhangzheng@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 01 Sep 2026 07:14:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01-Sep-26 08:54, Jan Beulich wrote:
> On 31.08.2026 17:48, Orzel, Michal wrote:
>> On 27-Aug-26 17:18, Oleksii Kurochko wrote:
>>> --- a/xen/drivers/char/console.c
>>> +++ b/xen/drivers/char/console.c
>>> @@ -31,6 +31,7 @@
>>> #include <xen/warning.h>
>>> #include <xen/pv_console.h>
>>> #include <asm/setup.h>
>> NIT: This can be dropped - I don't see anything relying on it in this file.
>
> Did you mean to ask for asm/setup.h to be dropped here, when that's entirely
> unrelated? If not, the other change you are asking for could surely be done
Why are you saying that this is unrelated? Before this change `max_init_domid`
declaration was in asm/setup.h and this was the reason for this header to be
included here. With this patch, the declaration is moved to dom0less.h and
therefore asm/setup.h is no longer needed to be included. I consider it very
much related unless I'm missing something.
~Michal
> while committing (and I assume the patch here is independent of patch 1).
>
> Jan
>
>> Other than that:
>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>>
>> ~Michal
>>
>
|
