[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 0/1] xen/arm: smccc: preserve arguments before register setup
- To: Jan Setje-Eilers <Jan.SetjeEilers@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Sat, 29 Aug 2026 19:19:09 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/FIHydVNpAcIW+o4XUBaZpAnTpDmfptdhgr0/6ayVjQ=; b=WW60+Kq8xmYggJO8WM26JWuYuzSw6z5kagK+ZXt/IVCtoZsQ6p1jikrwaYsmfpzJz3h3FN8XiOilCoxmZi1Ink/bRyesHYv20llHFID/QAmU3ed+foKJi0KN+cc2Pd56JjTK7lGpXMBU6Ipy9YNnwuIJVhIPc7qvpSmHl+++T/rMKUD6KhnafSlW+df5IYmZyAf22iA+vzAoxPxJw3xrVoR0XG2cfhaPcsUWrzbVSyqgZcj87uziRSk3X9m2jqosaaN/4CavnuA2GjCgE3eT9sdSj5Psq+hCqfF9vbuxg577iFIvNjp8UX7I45HLPsC9jTUt++AD0oSW2kbsVAsHGw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VIJ+N10bWUKP5Utpit4GdwIA4YA5Y6bdX/CCzeYjC/M351w417v6CEua3h7q7hQLIWa4DuCnJ4UweZThL1U2LOdfrTnd64YXFMv2mZlgo1og41wD6DtUPI7s/iqH9QFOIZrNlQUhCCcWxNq2qz8VUI68riV4KqspErcMKcKwjYTGTRTD8mR2kyNeYBBh4t5l8DOkuhAE1it5peS+Uaz19geQ8qZrReHBIRXquScqVI+eacX+saHCIQxcXjKTjDazi6IzjLrmUGKNrSEHBjhArh0BpkI+kZ0owemJhxbWxvglUiCW1bk2iemNu8MyachffaqzIdJ81rB+zxzDpgAUag==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Joao Martins <joao.m.martins@xxxxxxxxxx>
- Delivery-date: Sat, 29 Aug 2026 18:19:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/08/2026 5:53 pm, Andrew Cooper wrote:
> On 29/08/2026 3:12 am, Jan Setje-Eilers wrote:
>> Hi Andrew,
>>
>> While investigating an SMC forwarding failure after updating to Xen 4.22,
>> I found that firmware could receive different values from those passed to
>> arm_smccc_1_1_smc().
>>
>> Several public Xen callers pass get_user_reg() calls directly to this
>> helper. This includes the SCMI, ZynqMP EEMI, and i.MX forwarding paths.
>> The helper puts each value into its SMC argument register as the
>> expression is evaluated. A later get_user_reg() call can then overwrite a
>> register prepared for an earlier argument.
>>
>> The change in generated code appears after:
>>
>> 67bcf5eae709 ("xen/arm: Simplify type handling for SMCCC declarations")
>>
>> I am not sure which behavior the helper is intended to provide. Should
>> arm_smccc_1_1_smc() continue to accept arguments such as get_user_reg()
>> calls, or should callers save those values in local variables first?
>>
>> The attached patch is a candidate for the first option. It restores
>> temporary variables inside the helper, allowing all calls to finish before
>> x0-x7 are prepared for the SMC instruction. I am not able to validate the
>> public SCMI and ZynqMP paths on hardware, but their generated code now
>> finishes every get_user_reg() call before the final register setup and
>> smc. With this change, SMCs also work as intended on the device I'm
>> using.
>>
>> If the intent is not to accept function calls as arguments, we should
>> probably fix the SCMI, ZynqMP EEMI, and i.MX callers.
>>
>> Given the existing use cases, this seems like a bug, but your patch looks
>> intentional. It's very possible I'm missing the intended design. I would
>> appreciate your view on the intended contract.
>>
>> Thanks for any advice or help with this.
> Yes you're right. My change was buggy. It was actually part of a
> mutli-stage cleanup across several patches.
>
> I'll submit my own patch. I'm afraid your AI has put in whitespace
> errors where a straight revert would have gotten it correct, and left
> the 0 case still buggy.
In fact there's another bug. The SMCCC ABI states that certain
registers are clobbered, yet these are missing from asm().
It's also sad that this macro maze goes to the effort of making a
function-like-call which can return 4 registers by value, just to then
force it all to be spilled to the stack anyway.
~Andrew
|
