[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] kexec: machine_reboot_kexec() doesn't return
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Fri, 28 Aug 2026 11:55:00 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1787910900; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=iCyUO/jVJ1XT4h9kGqdidMW3hXotDizvbYQalvOgQTE=; b=UPeuUEMe2MKJQqBGzhRmT3XsMYTrevD5MVb6Mxpzwp592gybluxwY4XpLDkmRUIJXcQX yKQkk7Vfr0O3W467DXRHeFbtp8epvPh5ot45r1MHM8qGpF3nbRRURswIf43JqW7YMplqo 2aeSn3UypEZLi/8y5DnwIPTrc395z/6cZicfGMhHE8bJY2Px95qRa0RjZkrSGhPEOnffm /+CWvDs2kIQnlt4sjPHEQi44d/REsElVnkVheaXdEGhyCAIdQ4j57SX8e74tbQNfLoEL/ Ha/xCkZzzKyKJ7IQ1owroc/NUrdJ5RLC8mBkpoDfRmLAgqCHjif9HTTCQDVDL8YXcjlmq IOxUDn1H0Elon7+HtTlUYTcsSUxCKJxzREDU7eSKCnamKFgVsUjXV3J0VcbsqTnGh6ZyA hEPTR0f/TD7ougDJDBlF68Cwc8vHUjORS3NBkZq7PlKaweNZDE3tVdThoNb7i0V825mSe t7hv6hlc1GIH4IQCw8/zrXAPfPn0IhbkU/rdt7ybGpWu/E4i8NMceY8z+Wf0VG1gIVLmw pjovNFdCORTlu+UYJ/a7wCqZoSmr+FPN56x/tGdG7c3tNHoiOLgrcEIGCVYrEiSzGE0xI 4QdZGfUe2LSmoS3MtGthVdSzljZkTJ0mb78ry/pFYqKpjPYnhasviTYlR5hsh14=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1787910900; b=ikMy5bMPghpfJVk38GCkStPTsvdsPJrjp51BXgm6h90AmcM/6JdadIO1MOryeFvV9a1y sQaIF4EnzDm3DJvunPQvikxV0NJ7TY7iCCdPDeb8/ogNhWO41qwTEsS96IgFvm8yl9gvn NRQevjdaSgDp4+WaNCPubEoFa2HEWCcilywEHW/W4cnESzEVFUnzsxPERDtpoUFfpOiJK C1VcyDmTqcuzb4Lhy1dzd7zclaGTZMiSmtvm3rvTly8WA42zOHPetN0DmERIU7pFRI/xw nL4sb4PKGIoixCoYFB/HlEyhK4kWaE102uPeTqTyAXEWzhq3xnxv8NABusJAyc/HFOV53 m5x6e/Y/FNnEwnFe15g1Ywi50eRTZahfw8pikuolsQ3oYWSs3NmVTu1RhAtPwvQ9A9nHp IR9Ow/tfF0N5+tsreY4Ja7Q7F9SvGpqUpk3yCY6e5qz4Gv/MQouybNPUXdPTQzYX+bx1e s8Qu5R0msTm5r9tX2WYAgV5+jHEJVahc8FtLbPne9ayJ5J425v0MLBk9xTRiONwfi8rsx CkuwtGbE1VQp5mPaS1gDfP+eZAXN3FQdlIxLWsmEnfH1dD/Kt3HLwP/XPOBAIRr8AmTdk HV1P7T3zJ00UvnjDNFNaS9KsHAvKc59893Ul4rWUiv/w3+dAYFShjmz8whXw2DE=
- Authentication-results: eu.smtp.expurgate.cloud; none
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 28 Aug 2026 09:55:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-08-28 09:02, Jan Beulich wrote:
Mark it as such, and then remove the code following at its sole call
site,
for Eclair flagging that as a Misra rule 2.1 (unreachable code)
violation.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -401,7 +401,7 @@ void kexec_crash(enum crash_reason reaso
BUG();
}
-static long cf_check kexec_reboot(void *_image)
+static long noreturn cf_check kexec_reboot(void *_image)
{
struct kexec_image *image = _image;
@@ -409,9 +409,6 @@ static long cf_check kexec_reboot(void *
kexec_common_shutdown();
machine_reboot_kexec(image);
-
- BUG();
- return 0;
}
static void cf_check do_crashdump_trigger(unsigned char key)
--- a/xen/include/xen/kexec.h
+++ b/xen/include/xen/kexec.h
@@ -48,7 +48,7 @@ int machine_kexec_add_page(struct kexec_
int machine_kexec_load(struct kexec_image *image);
void machine_kexec_unload(struct kexec_image *image);
void machine_kexec_reserved(xen_kexec_reserve_t *reservation);
-void machine_reboot_kexec(struct kexec_image *image);
+void noreturn machine_reboot_kexec(struct kexec_image *image);
void machine_kexec(struct kexec_image *image);
void kexec_crash(enum crash_reason reason);
void kexec_crash_save_cpu(void);
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
