|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH 5/5] xen/riscv: add SFENCE.VMA after enabling paging
turn_on_mmu() writes satp to switch on Sv39 paging but never fences afterwards. Xen never allocates a non-zero ASID, so per the Privileged spec, sec. 12.2.1 "Supervisor Memory-Management Fence Instruction": "If the implementation does not provide ASIDs, or software chooses to always use ASID 0, then after every satp write, software should execute SFENCE.VMA with rs1=x0." The spec text around this rule hedges with "may be necessary", but RISC-V spec co-author Andrew Waterman confirmed on the ISA manual issue tracker that the fence after a satp write is not optional in this case: "The SFENCE after the SATP write is definitely necessary ... In general, you need to SFENCE after you've recycled an ASID. Since we don't use ASIDs in the Linux kernel yet, every context switch is effectively an ASID reuse, hence the full TLB flush." [1] The same reasoning applies to Xen: with ASID always 0, this satp write is indistinguishable from an ASID reuse to the hart, so the fence is required for correctness. Add the missing SFENCE.VMA to order those page-table stores before the hart's first translation under the new mapping. [1] https://github.com/riscv/riscv-isa-manual/issues/226 Fixes: f5035d480f7a ("xen: add files needed for minimal riscv build") Assisted-by: Claude:claude-opus-5 Signed-off-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx> --- xen/arch/riscv/riscv64/head.S | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 9c40512e61..7f6edc972f 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -98,6 +98,7 @@ FUNC(turn_on_mmu) srli t1, t1, PAGE_SHIFT or t1, t1, t0 csrw CSR_SATP, t1 + sfence.vma jr a0 END(turn_on_mmu)
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |