[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 37/49] monitor: tighten monitor_printf*()
- To: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: "Jason J. Herne" <jjherne@xxxxxxxxxxxxx>
- Date: Mon, 17 Aug 2026 14:09:33 -0400
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=pp1 header.d=ibm.com header.i="@ibm.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"
- Cc: Philippe Mathieu-Daudé <philmd@xxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Gonglei (Arei)" <arei.gonglei@xxxxxxxxxx>, zhenwei pi <zhenwei.pi@xxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxxxxxxxx>, Ani Sinha <anisinha@xxxxxxxxxx>, Laurent Vivier <lvivier@xxxxxxxxxx>, Amit Shah <amit@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Brian Cain <brian.cain@xxxxxxxxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Jason Wang <jasowangio@xxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Ilya Leoshkevich <iii@xxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, "Dr. David Alan Gilbert" <dave@xxxxxxxxxxx>, Hyman Huang <infra.ai.cloud@xxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, Zhao Liu <zhao1.liu@xxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Chinmay Rath <rathc@xxxxxxxxxxxxx>, Glenn Miles <milesg@xxxxxxxxxxxxx>, Harsh Prateek Bora <harshpb@xxxxxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, Daniel Henrique Barboza <daniel.barboza@xxxxxxxxxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>, Chao Liu <chao.liu@xxxxxxxxxxxxxxxxxx>, Yoshinori Sato <yoshinori.sato@xxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, qemu-ppc@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, qemu-riscv@xxxxxxxxxx
- Delivery-date: Tue, 18 Aug 2026 12:37:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 8/16/26 3:13 PM, Marc-André Lureau wrote:
Rename monitor_printf->monitor_hmp_printf, monitor_vprintf->
monitor_hmp_vprintf, and monitor_printc->monitor_hmp_printc, changing
the first parameter from Monitor * to MonitorHMP * to enforce type
safety. The implementation is also simplified: monitor_hmp_vprintf now
directly calls g_strdup_vprintf + monitor_puts, removing the virtual
dispatch via moncls->vprintf.
The dev_print() callbacks are temporarily using the MONITOR_HMP(mon)
cast, they are fixed in the following commits.
Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
---
...
hw/pci/pci-stub.c | 3 +-
hw/s390x/s390-skeys.c | 9 +-
hw/s390x/s390-stattrib.c | 20 +--
Reviewed-by: Jason J. Herne <jjherne@xxxxxxxxxxxxx>
|
