[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/6] xen/arm: report proper GIC version via XEN_DOMCTL_getdomaininfo
- To: Julian Vetter <julian.vetter@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 17 Aug 2026 14:19:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vates.tech smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xe80fhEQSwjndlQz7q67yiDsbz9eJTHhOn+Pkvtb0/8=; b=rLI8byiECUhBgzKtOMH6dP8C8oHf0sgvUAyFQZ9dfvSlp3wSSAyRmb30STZ0P0vTKHCmBu/a2zzhgly6xk3pfMZ3uDcdvbHTGrGO74HfrUm2eAkyfdvG9Iew3HdvadbvGlvQzsnEKQiSlyMBTCF02rkiaAKlupt6u4VMzwajCPSSe8Kx0qp+sMDcQko7DJQsUb4iye51+4XK5UlWy76nETmDr+J0kwiKBFm5KHFJPnY8uoxzSE91CSYmCJ8tFpLsIPDsH5Joa8Jn1I0ntxvwvcy5e5+TLYnSNkMEtA3lnWdxaPD695r6yi3V+a/X6QIk55WaCGVirI+nxp+1rEKvSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=whkLmkd0PAf58XYwjI8SftWaaMEgfcWC+yqqqlVpcz3gF/WJpXLz+fxYeUe54iFYrxGrag1pAsotWGdJPMUOftRmG9V6MzCDm0k+36p/wqhEVqZHIrJDzjX+E3DMMLgBdwC5U0iEUVvRdp6yGACMzOnurj+C1yzCt6pJP3q/FSoN+NWYJ6N45pZo3tVkkd56k1/+I930514AIGmWF9mDCW3i8teY0B8aid3naIPgAzbgAvPKCVdbDqt586zo2ShqzrEhokFBuexMWV5vgkpA6M7vic8waQlH3MNRz9Bl0uGSN1BRVAoR0mclMywJJDRKABASRehbsRUsgaQJCN3J8w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrii Sultanov <andriy.sultanov@xxxxxxxxxx>, Guillaume Thouvenin <guillaume.thouvenin@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Mon, 17 Aug 2026 12:19:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16-Jul-26 16:11, Julian Vetter wrote:
> When creating a domain on ARM, and passing XEN_DOMCTL_CONFIG_GIC_NATIVE
> for the gic_version field in the struct xen_arch_domainconfig,
> arch_sanitise_domain_config() resolves this to the approrpiate GIC_V2 or
> GIC_V3 version the domain actually has, based on the host's
> gic_hw_version(). That value is stored in the domain as
> d->arch.vgic.version, but can't be queried through any other domctl
> later. Toolstacks that create and build a domain in the same call
> already have this info from the createdomain reply and never need to ask
> again.
>
> Toolstacks that create a domain and build it later from a separate
> process do need to ask again. But, the ARM implementation only fills in
> info->flags and info->gpaddr_bits. info->arch_config is left zeroed, so
> XEN_DOMCTL_getdomaininfo always reports gic_version as
> XEN_DOMCTL_CONFIG_GIC_NATIVE (0) regardless of what was actually
> configured earlier.
>
> Signed-off-by: Julian Vetter <julian.vetter@xxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
