[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] acpi: reboot: log reset parameters
- To: dmukhin@xxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 31 Jul 2026 10:07:45 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, sstabellini@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 31 Jul 2026 08:07:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.07.2026 06:42, dmukhin@xxxxxxxx wrote:
> On Thu, Jul 30, 2026 at 08:26:38AM +0200, Jan Beulich wrote:
>> On 30.07.2026 02:18, dmukhin@xxxxxxxx wrote:
>>> --- a/xen/drivers/acpi/reboot.c
>>> +++ b/xen/drivers/acpi/reboot.c
>>> @@ -6,6 +6,7 @@ void acpi_reboot(void)
>>> {
>>> struct acpi_generic_address *rr;
>>> u8 reset_value;
>>> + pci_sbdf_t sbdf;
>>>
>>> rr = &acpi_gbl_FADT.reset_register;
>>>
>>> @@ -21,17 +22,24 @@ void acpi_reboot(void)
>>> * on a device on bus 0. */
>>> switch (rr->space_id) {
>>> case ACPI_ADR_SPACE_PCI_CONFIG:
>>> - printk("Resetting with ACPI PCI RESET_REG.\n");
>>> + sbdf = PCI_SBDF(0, 0, rr->address >> 32, rr->address >> 16);
>>> + printk("Resetting with ACPI PCI %pp RESET_REG at 0x%"PRIx64"
>>> (0x%x)\n",
>>> + &sbdf, rr->address & 0xffu, reset_value);
>>
>> As indicated on other occasions - %#x and alike please in favor of 0x%x.
>>
>> I also see no reason for the 'u' suffix on the literal number. Plus if one
>> was wanted, it would want to be 'U', to match the Misra-demanded 'L'.
>>
>> Also - nit: Indentation.
>
> Thanks for taking a look!
>
> This file uses tabs - I can convert to spaces, but in separate patch.
That wasn't the point of my remark though. Merely switching to all-blanks
indentation would be wrong. Converting altogether to Xen style would be
an option. My remark was about you not using the necessary mix of tabs
and blanks when the wrapped part of a statement want to align with the
respective part on the earlier line. I.e. here two tabs followed by 7
blanks.
Jan
|
