[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 4/7] xen/console: switch conring runtime allocation to xvmalloc
- To: dmukhin@xxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 20 Jul 2026 16:57:44 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 20 Jul 2026 14:57:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.07.2026 20:16, dmukhin@xxxxxxxx wrote:
> @@ -474,20 +475,26 @@ void __init console_init_ring(void)
> {
> char *ring;
> XENCONS_RING_IDX done, size, n;
> - unsigned int order, memflags;
> unsigned long flags;
>
> if ( !opt_conring_size )
> return;
> -
Please can we keep this blank line and ...
> - order = get_order_from_bytes(max(opt_conring_size, conring_size));
> - memflags = MEMF_bits(crashinfo_maxaddr_bits);
> - while ( (ring = alloc_xenheap_pages(order, memflags)) == NULL )
> + else if ( opt_conring_size > GB(2) )
... have this be just "if ()"? (I'd also suggest to make the "positive" case
the "if()" part and have the out-of-range one in the "else" body.)
> {
> - BUG_ON(order == 0);
> - order--;
> + printk(XENLOG_WARNING "Limiting user-configured console ring size to
> 2 GiB\n");
Nit: Too long line. Yes, format strings shouldn't be split, but XENLOG_* can
every well live on a separate line.
> + opt_conring_size = GB(2);
> }
> - opt_conring_size = PAGE_SIZE << order;
> + else
> + {
> + unsigned int order = get_order_from_bytes(max(opt_conring_size,
> + conring_size));
> + opt_conring_size = PAGE_SIZE << order;
Nit: Blank line please between declaration(s) and statement(s).
> + }
> +
> + ring = xvmalloc_array(char, opt_conring_size);
> + if ( !ring )
> + panic("Unable to allocate console ring of %u KiB\n",
> + opt_conring_size >> 10);
Why do you lose the prior behavior of halving the size until allocation
succeeds (or we can't even allocate a single page)?
Jan
|
