Re: [PATCH 2/2] {libxl,xl}: Add xl trigger debug

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 20/07/2026 12:29, Jürgen Groß wrote:
> On 20.07.26 11:27, Tu Dinh wrote:
>> Use XEN_DOMCTL_SENDTRIGGER_DEBUG to allow printing diagnostics
>> information of a specific domain.
>>
>> Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
>> ---
>>   tools/libs/light/libxl_domain.c  | 4 ++++
>>   tools/libs/light/libxl_types.idl | 1 +
>>   tools/xl/xl_cmdtable.c           | 2 +-
>>   3 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/ 
>> libxl_domain.c
>> index 37fcd92871..2d8290dbfa 100644
>> --- a/tools/libs/light/libxl_domain.c
>> +++ b/tools/libs/light/libxl_domain.c
>> @@ -2190,6 +2190,10 @@ int libxl_send_trigger(libxl_ctx *ctx, uint32_t 
>> domid,
>>       case LIBXL_TRIGGER_S3RESUME:
>>           domain_s3_resume(ao, egc, domid); /* must be last */
>>           return AO_INPROGRESS;
>> +    case LIBXL_TRIGGER_DEBUG:
>> +        rc = xc_domain_send_trigger(ctx->xch, domid,
>> +                                    XEN_DOMCTL_SENDTRIGGER_DEBUG, 
>> vcpuid);
>> +        break;
> 
> You are sending VIRQ_DEBUG only to one vcpu. Wouldn't it make sense to add
> the capability to send it to all vcpus of a domain?
> 
> 
> Juergen

It's a current limitation of xl trigger that it can only send triggers 
to 1 vcpu at a time. Perhaps a special vcpuid value could be defined for 
this purpose, then xl trigger can use this value when "all" is specified 
on the command line?


--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech