[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [4.22] Re: [PATCH] x86/domctl: restore all registers in arch_{get,set}_info_guest()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Frediano Ziglio <freddy77@xxxxxxxxx>
- Date: Mon, 20 Jul 2026 10:59:00 +0100
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ZIJPDOGMGXtHFAAoNyKXLbsC7KraedC+8OmoR5/4Gvc=; fh=wk0y1wP5tyDhLPHhZ130vdu8uO7RzrblIn679649v3M=; b=M9/BMeaFoRQ07y02dT6vZfy6w9HA0nizYmykXp0/kVWt1A4WKTby+PO+xGs7Q/y5cq 3C7HEz6GCyPZly6r4iPZ8d+W1TjmANGxxRpE6UHINry3zUuOK21WONXXEGSTCu/wim99 H3+hEO6vy5FA44nHNtTKiLqNrm5phVca2uEyep1nQAOhVlsQPT+JnycWuF2RiPcBpLx1 QqT9VA5NQ99pGwoRuC2ExNBGBDFPjBlv0KvXWc9vCQKIduCJBkxvTU23AMuLdXGrnkSS fcqMnojtDt3RLaRd32d9dbRULu0CtT3TPIOPXkvZ6JXMfbER59c95qVhzzf3oJwBTSmp 4SJw==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1784541552; cv=none; d=google.com; s=arc-20260327; b=A+6Wy4nkI9j4KoUf/0drF9wuFvqlT5BfDlo+vomG/yMwGtYRx9zx/gy9icDxN9Ka4u 50M8yiELrwP1V9PBkPRF12Xaimwb8RXHfxmQcIj3hhkGxJ2rv2MVKAqiMWEIUOFeCMb5 svSLzk66/9CPfC01InrMi7FOK4oQpybh2BJVANcmXAwp8fcEnPDtYaLAkKYoIGXSrpMo 7MneMQt8Usgg/Aeq1Ppcq/tVT7xwTr8mdGZ5tsZgjgeMZW3ukPfJPozF5z3pQKtsRHO8 8YOKB78G7f4n2/tHul50Igg/kqtReL1dNzYK8TkgGzdw9BBnsRGXTCILjCrxVKCmYJub QFVw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 20 Jul 2026 09:59:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, 20 Jul 2026 at 10:09, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 20/07/2026 8:19 am, Jan Beulich wrote:
> > On 20.07.2026 02:12, Marek Marczykowski-Górecki wrote:
> >> Commit 9f892f84c279 ("x86/domctl: Stop using XLAT_cpu_user_regs()")
> >> converted memcpy() of the cpu_user_regs structure to explicit copy of
> >> its fields. In the compat case, it intentionally missed few of them,
> >> named in the commit message. But the 64bit case missed also r8-r15
> >> registers, which was not intentional. This, at least, caused Linux
> >> 6.18.x crash when resuming PVH domU.
> > Oh, wow, what a bad mistake (including by me as the reviewer).
>
> Yes, I'm very embarrassed by this mistake. It also highlights a serious
> gap in testing which we need to address. We've managed a release and a
> half with PV migration plain broken before figuring out why.
>
...
Is migration tested by CI or just for some reason this was not captured?
Frediano
|
