[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v5 1/4] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
- Date: Fri, 10 Jul 2026 07:57:09 +0000
- Accept-language: ja-JP, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WUjxcg8ljp7x7N7BOOfF25+5H+4safU3iatwgkFjZc4=; b=kA9+s2QY2rMYx3VkhQPiIvRdCcxRhYLR3DikeBQ1hAmO9nx/CQcn/3KjZHXZbFuV7ZS1DR3ecXQUpUKCtrG/++nNNcQPSoyvdAKT97D5HeGYjv5mNPDh0Z8QBwwZxOSd5mMclmX6HqPC1oR3OJbEloHW/8PDU0t024FYOdwDlCM6C4YS29mymSLIwSJr2LFoA1FChldEBR7beTRRbGXJqaMVcGCFh3muLnkNOtesOvtN/CoJtq8cWYIr41cw5bA9Dl+C6Pv/PJu/5aJwe1scJuV2FeV7k0XIzFb3HgFl0zwzkuKh7i4QhW0+/1U1qRq0HSWU+REt0EjiSrRbtSABsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fkZili+YsvbUXTZfE1HLH47odFwZNVAwU6o89DB36czJdE35HWIVGv9cTapDFL/3xongNU6cXkZH7zHxBrhLp+c7CjOTIYC3QguX7lhMxE5lw4llUX5FNdBG827g2WLHegMPH1d1O85sHWXSreIPmGNfgraPVrF48pIV1AozuW3FgGPi9XcCMyncklQcnUv/s7vageXZYRlkr9Ex13z+sEjaiLZnxGw06S6TgqXZd3rXJtWN0bbzVUU2T/zGHxqPJ2fSQtm+85M2DBUnJ88nfr43F52YXSSHZaVQx7q9lDYaysX/XhlgB15IRp6qXFxW359OgcvZ2hQJxzyQRnx8bQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 10 Jul 2026 07:57:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdD+8qCEcYr5xaQEuU6MvjqTt1ZLZmWryAgAAAb0A=
- Thread-topic: [PATCH v5 1/4] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration
Hello,
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -23,6 +23,7 @@ config ARM
> > select HAS_STACK_PROTECTOR
> > select HAS_STATIC_MEMORY
> > select HAS_UBSAN
> > + select HAS_GENERIC_CPU_TOPOLOGY
>
> Please insert at the appropriate spot of this list, not at the bottom. We
> try to keep such lists sorted (both for easier lookup and for reduced risk
> of two patches colliding).
Okay, I will fix it soon.
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -191,6 +191,21 @@ config VM_EVENT
> > config NEEDS_LIBELF
> > bool
> >
> > +config HAS_GENERIC_CPU_TOPOLOGY
> > + bool
> > +
> > +config DT_CPU_TOPOLOGY
> > + bool
> > +
> > +config GENERIC_CPU_TOPOLOGY
> > + bool "CPU topology support (UNSUPPORTED)" if UNSUPPORTED
> > + depends on HAS_GENERIC_CPU_TOPOLOGY
> > + select DT_CPU_TOPOLOGY if DEVICE_TREE_PARSE
> > + select ACPI_CPU_TOPOLOGY if ACPI
> > + help
> > + Retrieve CPU topology information from the device tree or the
> > + ACPI PPTT to optimize virtual CPU scheduling.
> > +
> > config NUMA
> > bool
>
> I can't help the impression that none of my v4 comments were taken into
> account. And not just here.
I am very sorry, I completely overlooked your feedback on v4. I will address
all of
your comments right away and ensure they are reflected in the next version.
Hirokazu Takahashi.
|
