Re: [PATCH v6 13/16] privcmd: Add definition for new Linux privcmd to access new Xen hypercall

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Jun 19, 2026 at 02:04:58PM +0100, Frediano Ziglio wrote:
> diff --git a/tools/include/xen-sys/Linux/privcmd.h 
> b/tools/include/xen-sys/Linux/privcmd.h
> index 607dfa2287..7a3c41308b 100644
> --- a/tools/include/xen-sys/Linux/privcmd.h
> +++ b/tools/include/xen-sys/Linux/privcmd.h
> @@ -100,6 +100,14 @@ typedef struct privcmd_pcidev_get_gsi {
>       __u32 gsi;
>  } privcmd_pcidev_get_gsi_t;
>  
> +typedef struct privcmd_foreigncopy {
> +     domid_t dom;          /* Foreign domain. */
> +     __u16 dir;            /* Direction,  0 from, 1 to. */
> +     __u32 num;            /* Number of pages to copy. */
> +     const xen_pfn_t __user *pfns; /* Array of pfns. */
> +     void __user *buffer;  /* Buffer to copy to/from. */
> +} privcmd_foreigncopy_t;
> +
>  /*
>   * @cmd: IOCTL_PRIVCMD_HYPERCALL
>   * @arg: &privcmd_hypercall_t
> @@ -121,6 +129,8 @@ typedef struct privcmd_pcidev_get_gsi {
>       _IOC(_IOC_NONE, 'P', 7, sizeof(privcmd_mmap_resource_t))
>  #define IOCTL_PRIVCMD_PCIDEV_GET_GSI                 \
>       _IOC(_IOC_NONE, 'P', 10, sizeof(privcmd_pcidev_get_gsi_t))
> +#define IOCTL_PRIVCMD_FOREIGNCOPY                            \
> +     _IOWR('P', 11, privcmd_foreigncopy_t)
>  #define IOCTL_PRIVCMD_UNIMPLEMENTED                          \
>       _IOC(_IOC_NONE, 'P', 0xFF, 0)
>  

I don't think I can accept this patch until the changes have been added
to Linux. Also, I think it would be fine to squash this
changes into the patch that start using this new hypercall.


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech