Re: [PATCH v6 03/16] libs/guest: Reduce number of I/O vectors in write_batch

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Jul 02, 2026 at 01:33:05PM +0100, Frediano Ziglio wrote:
> On Tue, 30 Jun 2026 at 17:47, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> >
> >
> > This has the same exact subject as the prior patch.
> >
> > Either it wants merging, as they're both in the same function, or the
> > subject wants to be different.  Even a "Further ..." prefix would help.
> >
> > On 19/06/2026 2:04 pm, Frediano Ziglio wrote:
> > > Each page was sent using a different iovec item. This potentially exceed
> > > Linux maximum (1024).
> >
> > Linux cannot have a maximum of 1024 because this has been working fine
> > for a decade using 1028 in the common case.
> >
> 
> But the code does not call writev or similars directly, so there's no
> limit besides the sky.
> The result with 1028 is simply that you do 2 system calls instead of one.

Could you add something along those lines to the description? And turn a
sentence saying there's a bug into a description saying it's suboptimal.

With that: Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech