[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-4.22 v2] dom0less: Prevent division by zero in handle_passthrough_prop()


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Tue, 7 Jul 2026 17:22:48 +0000
  • Accept-language: en-US, uk-UA, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFi3uEwnIeZGQNeWi++DWXbjD/RgN6Pznd2g6JvFo4A=; b=rJ5DFO+zn8HnsjSLN43yqMQZ8cHN1E9/DvhUjrYd1hEF8b82Ac2OlDG9f4kZqEkJakWgwQ1hpRrvHNPEalVgPHK1R1fpEzze+Vo4zXZ37yCIVkqGY8n5NmZjEFNvbnpMLec69Vh1uoAg0Rcs++sLbzeW/NTPvxaha0RdP3jvxEnk+H44AFyIMWfC9K8MDnph9SFBOr/9aKuGNGRfvTG23aOjE2XTxiszkOIwgnmRLwvQvZL9+QPbT7xS4biX/exwiG6+9no91D3sOzbmqfH9QURYaVZ8Tn5brCwfWbUMQ4r+351+b6gkv+lk/xLnEizW+WbvLOe6HdDaXyWommByww==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lb4cYvdny89zcwpyPTeFoi+AHq3xwZDCzoOqlOvZGCvJPlM0VY1xcPC079XoXe/Ah+nFMQebycSrB6oHiYpXtpcztErjDCJt/9OxWa0FqDaK1P3QTu4dGQ9GnBJOG8N1o6tJXD0Z34TQDhDVmotJwNaZYFmWqucONWc9CR0lSxC/39SFLCeLtYtmpT00w5P0ATT8PqHbCFP+4KvNOxMMILb0l4tRueXQT2aFS0HmMiZgzxZyhqg4uQKwkxa2tE9JS+ihAxAhZ32KQaGWXP68vqFh0EZiRZawxZp3kJooEFpK3J5gSXiIrsBSGs3ySkSQpQmMsHe5HOEFTxmd1vMFfw==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • Delivery-date: Tue, 07 Jul 2026 17:23:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHdDjU70ZWnanEzpkGiW5tTx+TsVg==
  • Thread-topic: [PATCH for-4.22 v2] dom0less: Prevent division by zero in handle_passthrough_prop()

A malformed provided partial DTB specifying both '#address-cells = <0>'
and '#size-cells = <0>' causes '(address_cells * 2 + size_cells)' to
evaluate to 0. This sum is subsequently used as a divisor when calculating
the number of regions in the 'xen,reg' property:

    len = fdt32_to_cpu(xen_reg->len) / ((address_cells * 2 + size_cells) *
                                        sizeof(uint32_t));

This leads to a division by zero exception in the Xen hypervisor during
boot, causing a hypervisor panic/crash.

Fix this by validating that '(address_cells * 2 + size_cells)' is greater
than zero before performing the division. If it is zero, log an error
message and return -EINVAL.

Fixes: 9ce974c47588 ("xen/arm: assign devices to boot domains")
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
---
Changes in v2:
- added Fix tag
- added Oleksii's R-b tags
---
 xen/common/device-tree/dom0less-build.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen/common/device-tree/dom0less-build.c 
b/xen/common/device-tree/dom0less-build.c
index eacfd93087..6796851844 100644
--- a/xen/common/device-tree/dom0less-build.c
+++ b/xen/common/device-tree/dom0less-build.c
@@ -154,6 +154,13 @@ static int __init handle_passthrough_prop(struct 
kernel_info *kinfo,
 
     /* xen,reg specifies where to map the MMIO region */
     cell = (const __be32 *)xen_reg->data;
+
+    if ( (address_cells * 2 + size_cells) == 0 )
+    {
+        printk(XENLOG_ERR "Invalid address/size cells combination (both 0)\n");
+        return -EINVAL;
+    }
+
     len = fdt32_to_cpu(xen_reg->len) / ((address_cells * 2 + size_cells) *
                                         sizeof(uint32_t));
 
-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.