[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 2/3] xen/sched: Link CPU topology to scheduler
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
- Date: Tue, 7 Jul 2026 06:46:48 +0000
- Accept-language: ja-JP, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=feMlZfJtHOqlEdBjOIKXDlaHjBi1avph20RmCeUwH/A=; b=iZ+z3C9xCCascQX5dk3b62OlZmhNwtx4PcXHjnPwA3ojepq8xLgoiXJ6TjOJjtnagYhS2tI7QelvN6QZCF90gc1BzGgfgGGmxLajt3iqzLTa17H6VqUzLSZn0KySPL5LkIXjCo58SxmgCTWf9Ikvds2XedX0gUkXYfBWdyLIy8hDnSPhI5+MTHZ9o8YuK9H7p+QajbhpYxz0WebtLJ7cwfrwCa1xOM5R/7hv0cVCg3byz+FWboN+DneqW334Lvs06PrxGvMJNLeLNF3/4Dgo0BJZk6MICbEkrnkL3kIX7tiWKUZU+UEt6Lb7gmGpZHu/2vRzZJYsfUY3EUM1kEiXhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jVAMAglEubYKddE4+sLaRZJe7q+LH8PssV048s6X2/wHaCrOhzwQbNItnwGvJ4UNDGRCK8qtkP/63u8AsznGgVvRgJk6lJWmfUmuMs0Vh5nyNgWfrl16GGX38p0eCI5Yu1eKTeiOw2UubHINnm5qLzBPRJ/Z8UtNAIKDbVV71xD9aZO83tf5F4YcnYdKEhVqNOKsjYby0BEMBLFmAjV3fohdHhyk/a59N9LOEzeAG1cMigXKfmFjLlngBKlvWHF1BRpxVFMtUPzAlU0aKrP2SO7VXnamxuOs71P6QUfPrVHFagvDHGo8sBT5frxA78xhD71OLFBCPErm7TqZyJ9PUA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 07 Jul 2026 06:47:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdCsyKAF00d3K0tkaMQqAbl3ZPqLZbrPQAgAX19oA=
- Thread-topic: [PATCH v4 2/3] xen/sched: Link CPU topology to scheduler
Hello,
/*
> > diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
> > index 95946634d1..ada430f262 100644
> > --- a/xen/common/sched/credit2.c
> > +++ b/xen/common/sched/credit2.c
> > @@ -9,6 +9,7 @@
> > * Based on an earlier verson by Emmanuel Ackaouy.
> > */
> >
> > +#include <xen/cpu-topology.h>
> > #include <xen/errno.h>
> > #include <xen/init.h>
> > #include <xen/lib.h>
> > @@ -37,6 +38,8 @@ static unsigned int cpu_nr_siblings(unsigned int cpu)
> > {
> > #ifdef CONFIG_X86
> > return cpu_data[cpu].x86_num_siblings;
> > +#elif defined(CONFIG_CPU_TOPOLOGY)
> > + return cpu_topology ? cpu_topology[cpu].num_siblings : 1;
>
> Shouldn't here be CONFIG_GENERIC_CPU_TOPOLOGY?
Oops! I will fix it soon.
Hirokazu Takahashi.
|
