Re: [PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t

["Zi Yan" <ziy@xxxxxxxxxx>]

On Mon Jun 29, 2026 at 3:25 PM EDT, Lorenzo Stoakes wrote:
> Update __get_unmapped_area() to be parameterised by vma_flags_t rather than
> vm_flags_t as part of the effort to move VMA flags from a system word to a
> bitmap.
>
> We cascade the changes up to arch_get_unmapped_area_topdown() and
> arch_get_unmapped_area(), where, for now, we use vma_flags_to_legacy() in
> order to propagate the VMA flags.
>
> No functional change intended.
>
> Signed-off-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>
> ---
>  fs/hugetlbfs/inode.c     |  3 ++-
>  include/linux/huge_mm.h  | 10 +++++-----
>  include/linux/mm.h       |  6 ++++--
>  include/linux/sched/mm.h | 12 ++++++------
>  mm/huge_memory.c         | 21 ++++++++++++---------
>  mm/mmap.c                | 27 ++++++++++++++-------------
>  6 files changed, 43 insertions(+), 36 deletions(-)
>
<snip>

> diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h
> index 95d0040df584..b301ec90740a 100644
> --- a/include/linux/sched/mm.h
> +++ b/include/linux/sched/mm.h
> @@ -193,12 +193,12 @@ unsigned long mm_get_unmapped_area(struct file *filp, 
> unsigned long addr,
>                                  unsigned long len, unsigned long pgoff,
>                                  unsigned long flags);
>  
> -unsigned long mm_get_unmapped_area_vmflags(struct file *filp,
> -                                        unsigned long addr,
> -                                        unsigned long len,
> -                                        unsigned long pgoff,
> -                                        unsigned long flags,
> -                                        vm_flags_t vm_flags);
> +unsigned long mm_get_unmapped_area_vmaflags(struct file *filp,
> +                                         unsigned long addr,
> +                                         unsigned long len,
> +                                         unsigned long pgoff,
> +                                         unsigned long flags,
> +                                         vma_flags_t vma_flags);

Want to use two-tab indentation while at it?

<snip>

> @@ -812,19 +811,20 @@ arch_get_unmapped_area_topdown(struct file *filp, 
> unsigned long addr,
>  }
>  #endif
>  
> -unsigned long mm_get_unmapped_area_vmflags(struct file *filp, unsigned long 
> addr,
> -                                        unsigned long len, unsigned long 
> pgoff,
> -                                        unsigned long flags, vm_flags_t 
> vm_flags)
> +unsigned long mm_get_unmapped_area_vmaflags(struct file *filp, unsigned long 
> addr,
> +                                         unsigned long len, unsigned long 
> pgoff,
> +                                         unsigned long flags, vma_flags_t 
> vma_flags)

Ditto.

LGTM.

Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>


-- 
Best Regards,
Yan, Zi