Re: [PATCH 2/4] libxc: drop size parameter from xc_flask_context_to_sid()

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Jun 16, 2026 at 11:01:41AM +0200, Jan Beulich wrote:
> --- a/tools/libs/light/libxl_flask.c
> +++ b/tools/libs/light/libxl_flask.c
> @@ -21,7 +21,8 @@ int libxl_flask_context_to_sid(libxl_ctx
>  {
>      int rc;
>  
> -    rc = xc_flask_context_to_sid(ctx->xch, buf, len, ssidref);
> +    assert(len == strlen(buf));

Could you return ERROR_INVAL instead? Just in case this is used by
something else than libxl, I'd rather not crash the application.

Thanks,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech