Re: [PATCH v4 20/25] xen/riscv: create APLIC DT node for guest domains

[Jan Beulich <jbeulich@xxxxxxxx>]

On 26.06.2026 17:46, Oleksii Kurochko wrote:
> --- a/xen/arch/riscv/include/asm/imsic.h
> +++ b/xen/arch/riscv/include/asm/imsic.h
> @@ -78,6 +78,7 @@ struct vimsic_state {
>  };
>  
>  struct dt_device_node;
> +struct kernel_info;
>  struct vcpu;
>  
>  int imsic_init(const struct dt_device_node *node);
> @@ -93,4 +94,6 @@ int vcpu_imsic_init(struct vcpu *v);
>  void vcpu_imsic_deinit(struct vcpu *v);
>  unsigned int vcpu_guest_file_id(const struct vcpu *v);
>  
> +int vimsic_make_domu_dt_node(struct kernel_info *kinfo, unsigned int 
> *phandle);

Doesn't this belong in the earlier patch?

> --- a/xen/arch/riscv/vaplic.c
> +++ b/xen/arch/riscv/vaplic.c
> @@ -9,6 +9,8 @@
>   */
>  
>  #include <xen/errno.h>
> +#include <xen/fdt-kernel.h>
> +#include <xen/libfdt/libfdt.h>
>  #include <xen/sched.h>
>  #include <xen/xvmalloc.h>
>  
> @@ -19,6 +21,11 @@
>  
>  #include "aplic-priv.h"
>  
> +#define VAPLIC_COMPATIBLE "riscv,aplic"
> +#define VAPLIC_NUM_SOURCES 96

So for the IMSIC the host value is relevant, but for the APLIC the count is
an arbitrary(?) compile time constant? Why?

> @@ -29,6 +36,74 @@ static void cf_check vaplic_deinit(struct vcpu *v)
>      return vcpu_imsic_deinit(v);
>  }
>  
> +static int __init cf_check vaplic_make_domu_dt_node(struct kernel_info 
> *kinfo)
> +{
> +    struct domain *d = kinfo->bd.d;
> +    int res = 0;

I'm pretty sure I did point out this (or a very similar) pointless initializer
before.

Jan