[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.22 v2 3/4] xen/irq: handle IRQ being disabled while executing its handler
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 29 Jun 2026 16:29:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=skenQqgi0rsZhdYg0G7Y+Y41g07E7ApiSpos2CdHeH4=; b=yG/vPT6s1RPX5lWkYIAtIlAinuyBtw/Z3MlSHeBIFTyLvGefKTD3m+LlpDPWOqAWOxSz8QTQJlAs025RmRvRuEEhRYLfbji/2XIrDHOFM8eoLGlmh7IP8FH4v/xYQ3l36BjwSiWQkCXbYyITdB6LiFjtZ6xYCMBGudyf+FXAe4W3ksJyYgBm98SRQl1oYTflRdW/m9Qq016miBIfBC8rS2UO+My8P5xCV2HHCe96FUAqaGGMMesf0CefQWWEMVSjgpn33wh59111Er8gu7vMrQP34x1jky9G4YUF3ySOwRqwhEt86FlLTi/J8RLu1pbJ8loSx2TeM+evmqkMjEtgjw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aYKrFSHCob7lrcHPVgLsSJWzMKfGs2rh2odpkj6DZBE6x7jRDlOUGNd6DEworbXWAStGysMnU7+2ugL9SjQwwyXRZWYit6Xui82IeI1ETaydqkE/ifpGMkfew4WSB1OvPkjpkN8jyTZACTU5f6Dn4DlVFIhGteSpCelCDTBWOgk6uN0VN5wKnK1LS2HjBFWnoEWTtl81NaV6Ouh72fT2NwNyh+juEIi4GzLGma2AD1D7ClltN0fK4qzkD/d7+oNmGCfen4MRnHonmNCDpXH0F7GwskRCvgTKCZ90sb4krgrCpgnFR9462M9Ag01A9vo4LK5mYag3maP/DNLyYx5lKQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 29 Jun 2026 14:30:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jun 29, 2026 at 12:31:56PM +0200, Jan Beulich wrote:
> On 29.06.2026 11:45, Roger Pau Monne wrote:
> > It's possible for IRQ_DISABLED to be set while running the handler
> > execution loop in do_IRQ(). Such disabling can be done by the handler
> > itself, or from a remote CPU.
>
> I don't think the handler itself can legitimately call any of the functions
> setting IRQ_DISABLED.
Hm, yes, we still have no interrupt handlers that set IRQ_DISABLED,
but we will gain one in the next patch, where ns16550_interrupt() will
call disable_irq() that does set IRQ_DISABLED.
> > Check for IRQ_DISABLED not being set in the loop condition, as to not
> > execute the handler if the IRQ has been disabled.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Preferably with the description adjusted (or it being pointed out what I may
> be overlooking):
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
I'm happy to clarify the commit message to note that while we have no
instances ATM, but that future changes might introduce some.
Thanks, Roger.
|
