Re: [PATCH v4 03/25] xen: arm: update p2m_set_allocation() prototype

["Orzel, Michal" <michal.orzel@xxxxxxx>]

On 26-Jun-26 17:46, Oleksii Kurochko wrote:
> p2m_set_allocation() uses a bool *preempted out-argument that overloads two
> meanings. When non-NULL, the value written back (true) duplicates information
> already carried by the -ERESTART return code — pure redundancy, which the
> caller-side ASSERT(preempted == (rc == -ERESTART)) only documents. Separately,
> a NULL pointer is an implicit calling convention meaning "preemption is not
> permitted in this context".
> 
> Replace the pointer with a plain bool can_preempt that explicitly controls
> whether the preemption check runs, making the NULL-to-suppress convention
> type-safe and self-documenting, and rely on the -ERESTART return code alone to
> report that preemption occurred.
> 
> Since p2m_set_allocation() is called by the common dom0less build code,
> move its declaration from the ARM-specific asm/p2m.h to xen/p2m-common.h.
> 
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal