[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.22] xen/x86: Always strip xen.efi


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Frediano Ziglio <freddy77@xxxxxxxxx>
  • Date: Tue, 16 Jun 2026 15:28:52 +0100
  • Arc-authentication-results: i=1; mx.google.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=7Zn9w5al2/YZZ9V57YMa5T4QiMRs1kVYvrWWkCpQORY=; fh=xMgxCykwvpWY5mH3OuER2Pjr8NYP4c7sDzDS4rEH5ro=; b=Fgf7i72Vwxjs92mqq7yvoKTqxs9rUnw/LwJte2f+zSpaekpPzqP+drcGnJwx4KokeS b5DPwEzD26iy4HNZ9Y42JWHlDdgy/g3Xzl9R1NzvrygymjuZ5fcurxrLqOW72eChL3xx uxspCSeqQ/irOjDiQ4n+M58NGs3LSCSxQp3dZAmcoFIrIunfouFgrgD02Wm7Ii9BNoRL 2uwrFux5trewWuqbuhBUFn11mTj/+2iozRXJx3L1Vo7yAIEX4ELlu4Z/uhSEOO2LS/hd aNZmGQH8k39iFli5AJTcl342en2O9ziaxRX+E8bdQdQq3EOYNRIpvDRovB9Y9oIqbFNm qKoQ==; darn=lists.xenproject.org
  • Arc-seal: i=1; a=rsa-sha256; t=1781620143; cv=none; d=google.com; s=arc-20240605; b=GkIfhHT4HMRtNP0G6vQLs+Wo5PVRVDac0DbPeoIHQ84Zc6DTLNnNJo5JkSnVsiXrG8 nLiFoECw1dckZ27GE2DNuaUNtL9nu3aXq6+JsXcsrWK665vSYLVI6OtWGW6BdQhFgyzf bkoLnAt6XuQ/CuF/qjDczB4e1j8lOhj5Zc5L2gKiUwgEAGweXRp4QzUMX/ZJDP87bE8O dUc1bOVODt0GohEZkoZB1UUOOemT1ex7SVpkv5XOkFaDZj+T8+cRK/CqzI9c6CL8AIN6 +2lNRBRjxpB3AvgaeUDNrRWaEw986/HfXLpKTquYNFUaTMP3gZl2mdjRon7tEwitWz78 YVhQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 16 Jun 2026 14:29:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, 16 Jun 2026 at 15:15, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 16.06.2026 16:07, Frediano Ziglio wrote:
> > On Thu, 11 Jun 2026 at 15:42, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >>
> >> On 11.06.2026 16:38, Jan Beulich wrote:
> >>> On 08.06.2026 19:31, Andrew Cooper wrote:
> >>>> Some old versions of binutils ld managed to produce efi files which the
> >>>> matching version of strip couldn't process.  This includes Binutils 2.26
> >>>> included in Ubuntu 16.04.  Delete the workaround for this bug, and 
> >>>> require a
> >>>> less broken toolchain.
> >>>
> >>> And we're certain newer versions of strip don't do any harm to the 
> >>> binaries?
> >>> Already towards Frediano's posting I said that having looked at how things
> >>> work there, I'm far from certain.
> >>
> >> I should have added: An option may be to link twice: Once with debug info
> >> included, and once with it stripped. Personally I trust the linker creating
> >> the various headers, including the section ones, more than strip's (or
> >> objcopy's). Yet then I can only repeat my observation that linking PE+ from
> >> ELF inputs looks to be significantly slower than linking ELF -> ELF.
> >
> > That was also attempted. See previous versions. And no, it does not work.
>
> How exactly does it not work? When stripping debug info while linking (as
> we now do for the first two passes), the resulting image should be both
> small enough and correct. What am I missing? The only caveat I'm aware of
> is the Eclair scan, where we should avoid doing any work for the
> "auxiliary" linking step (the one not producing the binary that's actually
> going to be used for running Xen).
>
> Jan

One thing I remember was the build-id was not the same and debugging
tools could not work.

Frediano



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.