[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.22? 9/9] x86/HVM: more checking for XEN_DOMCTL_ioport_mapping
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 16 Jun 2026 12:01:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jwWE0W6pC8pK0Hu7aEEc5m4DUdaxFC1PXVuiP+f4pcI=; b=e2kJnYj98NpfS0ItjR5V2PPjTEuYzB/W/RjqAo6EsDC1nzi3UMW8ghAv+72WYD0DgvSpug9rirz3jlgwVftIhjN8rCp7hUC11oMgnXE/+bH/ompro775G96lzhEJh1fzRA8uAXZ0QSD/vsln6aOeiwr0yEVfghuI32QQWVx8j6naud4nC4ntRXN1z48d4OGkLicdv1pQVn5GYzJV3y9vRvs4NlhJAIo+jg6on7R6TgHJDR9rJNaTaXap/N6Z3T4M7fu90PVWn9F4ZNABgneN6bl+FGDXMXgDw+rAoXAXIao+2C7AwtMk0Nel7jAF99QCURC+lXcMi4nQRP9Bhq+BzA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NPFZ0Wet5jpj7m1llr3qfj/TyV5XxWQMpCBkEKTyC8RZA3VPLtCU02Yr3OHonof3Q8ZtQHrEn4oP5iVpkjRxtGI5emW4/36+jP+v4IeZXPwVhLA+uBNPNHCHXbaOfNAeknWhaS2RyGnbCiM8c+aHYAuGInFmjEzrKVzXToc0GV/gT/G7w/aBTOAo5P/tQ4zlplp6ezXsZ+D0Jv3ZjZvS5+4Tw/JaPwgr+IB13IZs5tryoo0Dyp/CsuC68BQrQij+s4IZAtxJ6/h+Jvc0IC7FiSVdMdQ4CePcevCFOjii+BYHNwe7bDPrP/PuLyn947uJFoYlv7DIndZ38Wcn5zmZPQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Tue, 16 Jun 2026 10:02:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jun 15, 2026 at 04:16:41PM +0200, Jan Beulich wrote:
> When adding ranges, only alter existing ones when there is an exact match.
> Don't accept ranges overlapping existing ones.
>
> When removing ranges, only remove a range if there's an exact match.
> Return an error when the range isn't found, and also don't call
> ioports_deny_access() in that case.
Isn't the ioports_deny_access() part stale now? As you remove the
permission adjustments in patch 8/9.
> Fixes: 192c4dabc344 ("domctl and p2m changes for PCI passthru")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Should "exact match" perhaps also include the guest port number? I'm
> uncertain here as that kind of conflicts with "add" being treated as
> "change" when the host port (and now count) match.
I think we want to keep the existing behavior and allow using an add
operation to change the guest port.
Thanks, Roger.
|
