[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] xen/scsiback: fix command-tag handling on pre-completion error paths


  • To: Michael Bommarito <michael.bommarito@xxxxxxxxx>
  • From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
  • Date: Mon, 15 Jun 2026 22:00:45 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aFn316IGv+KL1guyUZeCfFJv1oXasbSyu8/9/CADhq8=; b=u6GZgxDnhvF3f3bQjn4bU1z8fNtK7yiFrtrp6lMwTgOOeo4yHkJcNUpOvzVeb8uJfLR2WOFt2QJcCwhAO2qRdyN86fTIM4nleova7HPLl8eU9/3xXxFAXiDIJVCt0wVeoDm86Vnf1VtD98MvBXkXZMyEm9s+S2wrvhtS4AeTPSIVgmNeHS4UdOVyysg4vvwNMLthzUB2hsSej6tRGFw0vH+yQ0zes5Svxm7/qqkrVc7BbtAvnoD2Yill9ZfCPKdam3OOy5LCbP1lITP7FSAzxMITYywHGqBHHODDNFy4GDmDKPhgYh/tsukzQAsn+F2r8WfvRUjLscRohLD+ZSHtoQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RK6sV9HM5u0EuwtyAnWF8Y3fLAlgB1eAXBFeIxvI10DDR+rzwWDYAgNrpSkrYjQMlSiQi+obVyEtvbnr+5P6iSV10N6pWgLKSyGD7l8lSHmn9iRLMQ6VDxM1P/V66tOLDK2aWmxuqNPSOcMFXH//bAFdnb/WbOfkCU86tA64/lW/MhfYho3SvHicEUt5fJIRX/hPL43P03DgLhTrS+Qq5E9htEddNlVNq0yiKoUQXvhzKoN7VeIwR6l0MXzKgG9HmjBQpc3ESkFJDsquGFL7oQzfOHU9EQt0hyNNUko6iEZJAhEtJfAzyIhpBa/7sYNKR7zUrdnRZAWUqWvr7p/6Aw==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=corp-2025-04-25 header.d=oracle.com header.i="@oracle.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-oracle-onmicrosoft-com header.d=oracle.onmicrosoft.com header.i="@oracle.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
  • Delivery-date: Tue, 16 Jun 2026 02:01:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Michael,

> scsiback_get_pend_req() hands a pvSCSI frontend request a session tag
> and a zeroed se_cmd. Two error paths that run before the command
> completes through the target core mishandle that command and leak (or,
> in one case, underflow) the tag.

Applied to 7.2/scsi-staging, thanks!

-- 
Martin K. Petersen



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.