Re: [PATCH v5 1/3] ns16550: properly initialize booleans in uart_param[]

[dmukhin@xxxxxxxx]

On Wed, Jun 03, 2026 at 12:13:20AM +0800, Jiaqing Zhao wrote:
> .bar0 and .mmio in struct ns16550_config_param are booleans, hence they
> should be initialized with "true", not "1". No functional change.
> 
> Signed-off-by: Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx>

Reviewed-by: Denis Mukhin <dmukhin@xxxxxxxx> 

> ---
>  xen/drivers/char/ns16550.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
> index 878da27f2e..ed4e29ec25 100644
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -758,7 +758,7 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 16,
>          .lsr_mask = (UART_LSR_THRE | UART_LSR_TEMT),
> -        .mmio = 1,
> +        .mmio = true,
>          .max_ports = 1,
>      },
>      [param_oxford] = {
> @@ -768,7 +768,7 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 16,
>          .lsr_mask = UART_LSR_THRE,
> -        .mmio = 1,
> +        .mmio = true,
>          .max_ports = 1, /* It can do more, but we would need more custom 
> code.*/
>      },
>      [param_oxford_2port] = {
> @@ -778,7 +778,7 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 16,
>          .lsr_mask = UART_LSR_THRE,
> -        .mmio = 1,
> +        .mmio = true,
>          .max_ports = 2,
>      },
>      [param_pericom_1port] = {
> @@ -787,7 +787,7 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 16,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> +        .bar0 = true,
>          .max_ports = 1,
>      },
>      [param_pericom_2port] = {
> @@ -796,7 +796,7 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 16,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> +        .bar0 = true,
>          .max_ports = 2,
>      },
>      /*
> @@ -809,7 +809,7 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 16,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> +        .bar0 = true,
>          .max_ports = 4,
>      },
>      [param_pericom_8port] = {
> @@ -818,7 +818,7 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 16,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> +        .bar0 = true,
>          .max_ports = 8,
>      },
>      [param_exar_xr17v352] = {
> @@ -827,8 +827,8 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 256,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> -        .mmio = 1,
> +        .bar0 = true,
> +        .mmio = true,
>          .max_ports = 2,
>      },
>      [param_exar_xr17v354] = {
> @@ -837,8 +837,8 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 256,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> -        .mmio = 1,
> +        .bar0 = true,
> +        .mmio = true,
>          .max_ports = 4,
>      },
>      [param_exar_xr17v358] = {
> @@ -847,8 +847,8 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 256,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> -        .mmio = 1,
> +        .bar0 = true,
> +        .mmio = true,
>          .max_ports = 8,
>      },
>      [param_intel_lpss] = {
> @@ -857,8 +857,8 @@ static const struct ns16550_config_param __initconst 
> uart_param[] = {
>          .reg_width = 1,
>          .fifo_size = 64,
>          .lsr_mask = UART_LSR_THRE,
> -        .bar0 = 1,
> -        .mmio = 1,
> +        .bar0 = true,
> +        .mmio = true,
>          .max_ports = 1,
>      },
>  };
> -- 
> 2.53.0
> 
>