[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 08/13] iommu/ipmmu-vmsa: Implement suspend/resume callbacks
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 29 May 2026 09:45:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3OkPbLOrMqqyBoy2/s9F/mTHpozibR4ya9kIhxBsmh0=; b=hWaurzY9T3d6yHcJkE0agpJtQ+6XUshLfVKbcdB2J1lIuclnCMz3jsLILLT/cDPKVG3zeF2ef1kwRLNjyYAOME4IzSFeXkhRrvf+Nn7RZluidES4FxPGTbS4TFu9x0sILpTBg7XWPVBfKl3NkljpAqbquNpuFZl05U9LUa8H5eWDAgZWIF5X4sLppSHJRv8EEfLfUW4TeZgeebO+c4S0hghAPcrXFWJeah6utU9XMFS8Xwu7xXUoN8HZ4YwzTO+pik+JCALJRm7YKEOiS5EOH0QDjz4bMzhFJoKW/q/5wFVqTZ0nHW9wwktKiEnq/as5lmsg4iCo/vRCOAYpJiUrqw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3OkPbLOrMqqyBoy2/s9F/mTHpozibR4ya9kIhxBsmh0=; b=VYFlml6gUrM1CGs3jt3le3meGPl0mf21vFlE+bwASbpb8eMsKoCEcnO554VmlhgJ/smZXi3GXFK0pOL0foMmsNPnrqEs1ZvpoQi+Tmen4dI6C5w/fMNEpEL4FKMi7eqIlEaEFMvMnQ3D1izzFuQ4S9FK7AcPQF/3Ba2WeCyljhv/vhLGsHY5h/Ebi8r1de6bdwqVkUVvsPUhU6exjPxf4aYa18NzpQomOtOWOI04QoDlCxe0SAOL+OK+tGook8flHPYYuLS93t+yFmW64+Uuch1lQ/bFf6Jx7ToOl1eGp4oqRc3Cma/axVCWBQew+W8QgKSl2+KkEguc5CbrSb63xA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=x8pJF8pHkBG9OtMbZYR2iemNiCRmhtu1NK3LsBRhmvnNMXh0aJqTdaXn6lMHydpoUXgpLMqUB5G7W+uRFTaQiGa4WEj/VNMzqlXWrW8tGymu0DTntW9xRordvlHcg0ViJ118TC892YfCi7tblFv1WFEf48Vky2HoXuSz6LklvZ3qpNtH3e2yrQvX/RSCvYRZLke4h47f7rd+MO9FuvrvWnv49u6ohLI/Z62o3sCOy/0jHPAB8EbqzZxtsfB9jWQWYhFJBcDWoep56uYUFjpI5zoh+xQqAE8/qqhvbzJ60O7NCB044arbbI5Wz83r2d0tjKErt1KA7XB4XHmTbkVvKA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hk5utapGOZExYvq04qzZyk+RXq0iQEYwEUWcEAwzmf3xiYm8IK5G7zT1xMFtixPgpo8Kb6hce86Kf0FUsbSflms2enq4to53afch2d27GaeRro7JCd3UYY7pCnRd89Y3eTk/CUI/KZ5NXm729CWGNQFCkQofBLJhCoZUPsJbIQ5EsvveEs1dCSkGIc8dyzJeSK2fC0N5IUIijbFV/MA9W14rrVxXQU0rop/+9pAYJSxKHUy8hLnaX8v3csUvF6rPqSlstUDpq03IEhrlPgf91gJPvq46H6QGlNlVP/7yfmTGqBd7QS/LZI331j4F7PY61EdwhD3BbqMKhniAX8H4gg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 29 May 2026 09:47:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc6UoH9mMqjMgbj0ORE0RKSkpfJbYkzScA
- Thread-topic: [PATCH v10 08/13] iommu/ipmmu-vmsa: Implement suspend/resume callbacks
Hi Mykola,
> On 21 May 2026, at 18:45, Mykola Kvach <xakep.amatop@xxxxxxxxx> wrote:
>
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> Store and restore active context and micro-TLB registers.
>
> On resume, restore Root IPMMU context state before restoring Cache IPMMU
> micro-TLB state. Cache IPMMUs select Root contexts through their micro-TLB
> configuration, so restoring Cache micro-TLBs before the Root context
> registers are restored can expose stale or uninitialized context state.
>
> Tested on R-Car H3 Starter Kit.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> ---
> Changes in V10:
> - Iterate over registered IPMMUs in reverse order during resume so Root IPMMU
> context state is restored before Cache IPMMU micro-TLB state.
>
> Changes in V9:
> - set dt_device_set_protected() only after ipmmu_alloc_ctx_suspend()
> succeeds, so DT devices do not remain protected on allocation failure.
>
> Changes in V7:
> - moved suspend context allocation before pci stuff
> ---
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
