[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 05/13] xen/arm: gic-v3: add ITS suspend/resume support
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 28 May 2026 18:10:51 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EioLAprl2wBjX9h1TPA/LTjqJ4EjN2p0DO3Ykm8XES8=; b=fJabiG6QvIeCSgka5DlXrpPhFebYh00WU4ORmmbcmvFcZvwXQ+OlUbCMeblGwA/rFVunMXrNUjGQp+MxLNdsnhaC0w8uidDltdU+/Nyri13r0oJaBri6aKgqSWYxq11SypCKHajwQ64+WB3A40KX+MD/uO9b2hc6acZcFAPgINx6hDD9WV5dpyfNINiYTgtSSzARuIgWccl/GrljMpMzwwu23WPy4lbCcgI4tZmxHKv6w/S8L2Ri7/qcM7+rZyaqFrBIruFMw0VyvlalXT9jkQDibW/Tl2QbUxSUTCTbVMN/vYgpXrrlB3G5PcYRaSkI3FeYa/IoTCvaAVsxIfQkrg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EioLAprl2wBjX9h1TPA/LTjqJ4EjN2p0DO3Ykm8XES8=; b=FjLun/sXSS9Q4hFflNKlTKRkz8Hk2xWRh9C3R0A8WspC+4/BTi1/wMyH94vQI5P2PM0QEesJiwp3fOCoHRJ5LrC4W5fpJSdjvdCXzUqdJ8c4tzT7x/+2g04jUC2dnBdGPv5t36YA6IWcpLbBGxQdPshG8Ig23hyDF7PNBLi45IkYe8y7p58GB8daEQOxeElevaB4ZSq/sbylf8B/aMhaK1XYk8KXQmE9twoPgsgGq2BvyVRnuCun+/mDOqPIkf/GB73WK5wSQzzzf7pnVvMdC3ZqlebKJkV9gn3gXZHXvf4aT6RWuaeLqv1Z+K63Nbnw6PVAGE3nCRrpNFmtxHyItw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=vUt9OC6Sa2ZMnZmeWgVE+wQJQXFd+MTpDhy8JaSAOJ/6lH1LXiztv6ba927CzhEm2UllIzJ6HNAfNSpImP/812KvlVmBe+zhwmpGW3GmQ6CPBo71Z5kOorhNJLCxwNaOBcK0PsTLgmPnZltOkZNYm62HSk7rifydU7LDNwH//SJnaYjKTyZYiQL32KihhuQnAazXGHpgjk8QWoE0azNwgr5sVtZmEb1uoP05M9HDVu3X7B/6mzDHH3PXwuAQKMt4KDAhf6FarI1hpnadAMKf50X3vy5QARmHchHDXnAKcVdOHi8Q3ARhXBT6LdDo9X8TUhnNrm5iqaDXpUGNu++X6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EcYFc24BlwsSAhaETb7mWFO7qeOgYsvXume8Q8Lu2VxaChrVh8a/Xue5ShrzgTPedWqtpTQQBbciRlzVGNkQsZzsBOCqPF7fZKOeDcAz3XrRBRvGjMA7TEBjWSaygy+wkXr6XgBope5EQCA2Ka6i+TbQFrNfnb1VpxwV1DyaLTmvzgOPUwnuu7Qd2xuw1s+RzK+UxNP3UEWw3eTr17DnrXAwB4tP3KDe1vgMCi7Fvgd76qh3l6YXNSScks3Rn+uJ2v3AHpLYD8J0DdBF1aizWkXAFx5ZEfIhEfvr7bvA59EonTxR3UQ2QxU0GVekKn+gINuVGvBUq9DA6eK9YTkE0w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 28 May 2026 18:12:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc6UoGT/kfd1Pv6US/NK5RLp1zNLYjx+kA
- Thread-topic: [PATCH v10 05/13] xen/arm: gic-v3: add ITS suspend/resume support
Hi Mykola,
>
> +#ifdef CONFIG_SYSTEM_SUSPEND
> +int gicv3_its_suspend(void)
> +{
> + struct host_its *its;
> + int ret;
> +
> + list_for_each_entry( its, &host_its_list, entry )
> + {
> + unsigned int i;
> + void __iomem *base = its->its_base;
> +
> + /*
> + * By the time Xen reaches gic_suspend(), every domain is already in
> + * SHUTDOWN_suspend, so ITS-targeting interrupt sources are expected
> + * to have been quiesced by the owning OS before SYSTEM_SUSPEND.
> + */
> + /* Preserve saved GITS_CTLR state, excluding read-only QUIESCENT. */
> + its->suspend_ctx.ctlr = readl_relaxed(base + GITS_CTLR) &
> + ~GITS_CTLR_QUIESCENT;
> + ret = gicv3_disable_its(its);
> + if ( ret )
> + {
> + writel_relaxed(its->suspend_ctx.ctlr, base + GITS_CTLR);
This is writing enable from 0 to 1, while quiescent is still 0, which is
unpredictable,
however it’s the same happening on Linux, so I would leave it to the maintainer
preference.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
