[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 07/21] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
- Date: Sun, 24 May 2026 20:34:01 +0000
- Accept-language: ja-JP, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nEoMXAXyDkp2zpC2ykC8ZKgQzCk0LzpMSuPq0fsUMnw=; b=m3vadv8gj6mFQNmhxh+VYGg9tmT8EkdRANA8248K3SxI/gcW00Lr7mDBFfBDiuPAVmrX6NNqu1LwJiE0IKeN5S5ohd8beYL/bqNQ1YIFvK+OjgZY46ndoHXm3K5LWJRpUi9jJ/T1kaQhfF3awqtjQMt1MBXec1GEUaqQnzflQf+KnOpvjjZ5OsF6QB55+iZMaqfND0rf52JPtL7PUsFc1dY+xttdb76E/oAN5V9skpMY/KHsg9F2gnPbQqkFfpBxemqiFftFguKfkMqrN8uJ9T1+MxBgP/w/O8r9HMN/Vc3wLpilg4LRIMtLOeIW8NtkLqR9gutYnlHWeEOAxeTbCw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hR1P0BwZ/j/ImkyhYtDUQ2Tb9eD3vha4vqcr18X3Qi/pg3xBVAfOYmVon7pRybEvhj197i9B/HWiyFMyxOQZwociFqfPVTMYR5BxbgoNlo7g79m/tUSDC7BL41NWZ1SBvPFok8h0JQIxdq0hU1MRDhuJW9wSnkg8l/+Sd+WkIKkaA+4weyc+0YqKBqlq9dLXDRz/6I4QWumEIZjO42Zk4nBDfql4CK3i8cDtMWuHCEPOZ1/cB4BpTTsQxvf72Jjrm4grLtUhW90RUSK4iFGwaY91QKZ2eMudQs1PAHoQIaVg2W6AumdrDtizSBX7jZSF5Y67+sFTSHn6YaGgetCbBA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "anthony.perard@xxxxxxxxxx" <anthony.perard@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "bertrand.marquis@xxxxxxx" <bertrand.marquis@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "dfaggioli@xxxxxxxx" <dfaggioli@xxxxxxxx>, "gwd@xxxxxxxxxxxxxx" <gwd@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Sun, 24 May 2026 20:34:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHc6xCjYQ+8FIQyC0GVlBooU9qyFbYdTBoAgABWAuA=
- Thread-topic: [PATCH 07/21] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration
Hello,
> > xen/arch/arm/smpboot.c | 6 +
> > xen/common/Kconfig | 7 +
> > xen/common/device-tree/Makefile | 1 +
> > xen/common/device-tree/cpu_topology.c | 307
> ++++++++++++++++++++++++++
> > xen/include/xen/cpu_topology.h | 42 ++++
> > 5 files changed, 363 insertions(+)
> > create mode 100644 xen/common/device-tree/cpu_topology.c
> > create mode 100644 xen/include/xen/cpu_topology.h
>
> Nit: New files' names want to use dashes in favor of underscores.
ok, I will fix this in v2.
>
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -188,6 +188,13 @@ config VM_EVENT
> > config NEEDS_LIBELF
> > bool
> >
> > +config DT_CPU_TOPOLOGY
> > + bool "Device tree based CPU topology support (UNSUPPORTED)" if
> > +UNSUPPORTED && ARM
>
> Instead of open-coding ARM here (and also in patch 03), please consider using
> another ...
ok, I will.
> > + depends on HAS_DEVICE_TREE_DISCOVERY
>
> ... HAS_*, just like you make use of an existing one here.
How about this?
"depends on DEVICE_TREE_PARSE"
And I'm wondering once the UNSUPPORTED tag can be removed, I would like to
eliminate DT_CPU_TOPOLOGY and make the CPU topology feature always enabled
whenever Device Tree is supported.
> > --- a/xen/common/device-tree/Makefile
> > +++ b/xen/common/device-tree/Makefile
> > @@ -11,4 +11,5 @@ obj-$(CONFIG_DOMAIN_BUILD_HELPERS) += kernel.o
> > obj-$(CONFIG_STATIC_EVTCHN) += static-evtchn.init.o
> > obj-$(CONFIG_STATIC_MEMORY) += static-memory.init.o
> > obj-$(CONFIG_STATIC_SHM) += static-shmem.init.o
> > +obj-$(CONFIG_DT_CPU_TOPOLOGY) += cpu_topology.o
> > obj-$(CONFIG_DEVICE_TREE_NUMA) += numa.o
>
> Again for here and (apparently) an earlier patch in the series: This file
> looks to
> be sorted alphabetically. Please don't blindly add to the end.
ok, I will.
Thanks for your advice.
|
