[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] argo: correct logline in ring_unmap()
- To: dmukhin@xxxxxxxx
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Fri, 22 May 2026 20:21:53 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=SllpBOG4I8HIjH+P8zdU6RFQYgr0es/ndiJmyiv+G6E=; fh=074dSOZR2TjZuH9KX7pMcX1QOxphcb/LlKcediamujk=; b=MsubFfZgxRRaeh5bdzYsRvzFLexN7jTMBpJrrRrtNCnPSVJUdMKpdlgPLHWwrNVIAM MGyJ4SAFkDNvAx5gTJDGyUSKJjJO8IdDOowPwb6nCBA82xHk593NkjBo1ZSGFqiFQAWH J1SCNocGp+QQuN07lX91Kea6C7WUBEohlbJhBfCqDBJeRFeP9E9byiYrqox/6g+84PRr 6Orq4oJhQT9ltoWDmFrqj14sn80hysEFOOeggvuKw5N+StGEoWEWLiG2YlqYnBoD9U2G iwGSsTys8D90KEp20I8+7LDmB7GTK6S0jizy1YXG3jmLU4g0kT2/cfsPMncUnezMUaLD kl9g==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1779470525; cv=none; d=google.com; s=arc-20240605; b=Ejfgr2X/mgtvknTCzA6fOps6avwwAd06VVgu6IHD+XjSC7WtdGWcQoCH+mVs1SP62v x173wvpexMA70YCduHtFNcttj8umV6iEEuloRTrkJhNvMCfeWlcPld/6rpYZ6jv0vx8p zIDQaELDL2Qg7ppZTi0HDGNkcGUq6H2yPJALGT9RvIUry+Y9cbFbDtaW5uIH+rb5aqDa XQ+LazeyZdy4T078gIg7J9061xiU39Vv+nQDcENxP4sLh8SclDKqvgctjItH6eyvBwzd YVdLXWQSVH1qe5blrN1bNxsk58jhAPz4iUSG/hyd3wJhZ3mSwHJTmTHz4Q+CPTYwxOZB 2BUw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, christopher.w.clark@xxxxxxxxx, dpsmith@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 22 May 2026 17:22:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, May 22, 2026 at 7:53 PM <dmukhin@xxxxxxxx> wrote:
>
> From: Denis Mukhin <dmukhin@xxxxxxxx>
>
> Drop XENLOG_ERR from the logline since argo_dprintk() already injects
> the proper log level indicator.
>
> Also, drop "argo: " prefix, since it is also injected by argo_dprintk()
>
> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> ---
> Changes since v1:
> - dropped duplicate "argo: " prefix
> ---
> xen/common/argo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/argo.c b/xen/common/argo.c
> index 98a3db7fd070..5da14c929e14 100644
> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -474,7 +474,7 @@ ring_unmap(const struct domain *d, struct argo_ring_info
> *ring_info)
> continue;
>
> ASSERT(!mfn_eq(ring_info->mfns[i], INVALID_MFN));
> - argo_dprintk(XENLOG_ERR "argo: unmapping page %"PRI_mfn" from %p\n",
> + argo_dprintk("unmapping page %"PRI_mfn" from %p\n",
> mfn_x(ring_info->mfns[i]), ring_info->mfn_mapping[i]);
Reviewed-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
~Mykola
|
