[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] argo: correct logline in ring_unmap()
- To: dmukhin@xxxxxxxx
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Fri, 22 May 2026 09:58:20 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Aphvrh3o4r9AM14USpcWUYSwrDUfewqP4MvO0SNGqVg=; fh=074dSOZR2TjZuH9KX7pMcX1QOxphcb/LlKcediamujk=; b=WQivLxi3pMax5hl2dYDrXVskvr69Y3fqKBfbGeOo9g2XKFjHmmO2pOj30T0rySZ0rS CyTBVnUF+DWRebPs5jDCPdrmNSa1Sczq4q+asgpsCq8+llDODcKfcHY+comP2eqKbafn pt1jrtV6EOpevyOzBkj+02ai+CHRl31SDQADqHAiChk5kJt2/kWiQWth5zjRhSX0+68d Qpfkz8vZHJCsStGVCwrTVB7nZSttntxKoIAwVEijKcnBo4lJRwhKbmpwRnoprqIKWXIb mKBbMPL/9hCOwtVD6katGSOS7iKdm+R+YlFyU3oqTpkY8lhrEH5CMNI9fjHae5IFjPjz FiOg==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1779433113; cv=none; d=google.com; s=arc-20240605; b=F2zYkLjn0qE/rmm+lvUrPboECtx1vp4+L6rXLHsED/664RRswvodnB+i0AJwJ3YZKM kR0195hdtSkWg/aOpeT3h5WhGnPlo6J8Jd1GVOZ983shjQlpTAWfU7yWjEwyhOKTlMYq umKMfWVdM/uLu8qwbQXGetW1pBy0+lGVdLxxLHZ5x3llExm8wLFUU9eAtZ2gAbUZucLI XA0760YJYoRW37VJv2Otjl/IPkGUMEf19QMcSFD1G9x7awIT5aeVIYyQeLtPQHqRP7Pk qSaKhIG9B5NJrDN4P+ZOeFhrSB2vRW55eXG+LQJhGpzNkluap4k/JMBOC+/SgGrHXIEI PhoQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, christopher.w.clark@xxxxxxxxx, dpsmith@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 22 May 2026 06:58:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Denis,
On Fri, May 22, 2026 at 2:26 AM <dmukhin@xxxxxxxx> wrote:
>
> From: Denis Mukhin <dmukhin@xxxxxxxx>
>
> Drop XENLOG_ERR from the logline since argo_dprintk() already injects
> the proper log level indicator.
>
> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> ---
> xen/common/argo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/argo.c b/xen/common/argo.c
> index 4f894470698e..c66632486800 100644
> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -474,7 +474,7 @@ ring_unmap(const struct domain *d, struct argo_ring_info
> *ring_info)
> continue;
>
> ASSERT(!mfn_eq(ring_info->mfns[i], INVALID_MFN));
> - argo_dprintk(XENLOG_ERR "argo: unmapping page %"PRI_mfn" from %p\n",
> + argo_dprintk("argo: unmapping page %"PRI_mfn" from %p\n",
Same here: argo_dprintk() already adds the "argo: " prefix internally,
so the explicit "argo: " should probably be dropped as well.
Best regards,
Mykola
|
