[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] vPCI: resolve MISRA R10.1 boolean arithmetic type violation
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Fri, 22 May 2026 06:13:39 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cSzIkcZnBN1lM7Zv/8++NndRVXnA68TaGTwQobbZpQ4=; b=GimbDMOIDurDmlFc4AQopGnhj3YjxLiTFSPtNqyuHbFKQHixHZP2hCyv1/An2LCmLDRoe+RBwKChyibtj50bNdB70HcRVoBbXB93/BRBufFCBuvPIfZX+HTmEXfZdw7DNNvhDJUbK3U+VDdrILEovDdqZQc5xuuyiIGP5WUmpu9xNG4IZTtj4D+zwtTQBGee3NEa7ykrUZDSPS+d2bKbHhVaqpno3g1YJJC6M/dUtXKQGN6fjcN426NWxqD6bsMQYNfaV+PU3/0j+TM/6AFVtQPYZHNvse7SQsjC7pGgFAMB5ScD9WyxA8xle5jbdNLostoO9YXbwmwifmOCrAO/Zg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Px2lZzmUJiAX5+wLOWezHi+88VpkZ1YpsXZZcmv9BlakVqh/NbGipaSe1zlaZy9xv3cTY9CNDRPRQp64zAqlLkaNSLvK9G19aKX1x0KWMh5kg8qlLRW1e0AUCo7kzxuWZEFMjBgwr7YObzbKKrlDRMsNTwLbZMP9d/NIf1ux8GABJ/gOJHvZh9jZvuLfznGE8mZEn9OHd7ioy3yMT5m2YCsFHgrw8Xiqtl3rsGWf01iYqiZ4QA051yTMX5pZco8SjHKSiMBf09BYzDzhDcNdUUWQzPWaiQTrqfiaeUGm8ANypQSSbtUBeJ9gZIdjzsbw1ucvXsis15rxRsgYLy3a6A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Delivery-date: Fri, 22 May 2026 06:13:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHc6bIh2sSAML9OckiCBnGq/+88iw==
- Thread-topic: [PATCH] vPCI: resolve MISRA R10.1 boolean arithmetic type violation
MISRA C Rule 10.1 states: "Operands shall not be of an
inappropriate essential type".
Boolean values cannot be directly used in arithmetic operations.
Convert boolean to integer in vPCI header bar index calculation
using the ternary operator to satisfy strict type checking rule.
No functional changes.
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
Test CI pipeline:
https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/2545399814
---
xen/drivers/vpci/header.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index a760d8c32f..2b7f78728d 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -586,7 +586,7 @@ static void cf_check bar_write(
if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
gprintk(XENLOG_WARNING,
"%pp: ignored BAR %zu write while mapped\n",
- &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
+ &pdev->sbdf, bar - pdev->vpci->header.bars + (hi ? 1 : 0));
return;
}
@@ -647,7 +647,7 @@ static void cf_check guest_mem_bar_write(const struct
pci_dev *pdev,
if ( guest_addr != bar->guest_addr )
gprintk(XENLOG_WARNING,
"%pp: ignored guest BAR %zu write while mapped\n",
- &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
+ &pdev->sbdf, bar - pdev->vpci->header.bars + (hi ? 1 : 0));
return;
}
bar->guest_addr = guest_addr;
--
2.43.0
|
