[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 3/3] xen/libfdt: fix UBSAN null pointer in fdt_property()



Hello Michal,

On 5/19/26 11:37 AM, Orzel, Michal wrote:
We treat libfdt as external library and we don't accept any edits here prior to
first sending a fix to libfdt and then cherry-picking a patch (in fact, afacit
we then do the libfdt version update).

Thanks for clarifying that.

Just to be sure I don't confuse something.
According to the commit ...:

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
Date:   Thu Nov 11 23:27:20 2021 -0800

      Update libfdt to v1.6.1

      Update libfdt to v1.6.1 of libfdt taken from
git://github.com/dgibson/dtc.
      This update is done to support device tree overlays.

... I have to send this patch to git://github.com/dgibson/dtc, right?
Yes, that's the main DTC/libfdt repository.

The patch to dtc repo was accepted and merged:
https://github.com/dgibson/dtc/commit/f57e7df35df4a301961cbbf9433ba4e85c2ee5ed

But current version of dtc is:
  $ cat https://github.com/dgibson/dtc/blob/main/VERSION.txt
    1.7.2

Does it make sense to backport just one patch to Xen instead of updating update libfdt to 1.7.2 as it would be necessary to apply 61 patch on top of Xen's libfdt 1.6.1:
  $ git format-patch v1.6.1..main -- libfdt/ | wc -l
    61

~ Oleksii



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.