[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] automation/eclair: export XEN_TARGET_ARCH during assignment
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Tue, 19 May 2026 13:09:31 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1779188971; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=ARXqPp9NirDiaMmgJPdBfuv/CUClwWWJ8uBW5c1zmZc=; b=5Kl9TY0jMe9k5pBLZuOnV/LNteUKg4L15zb4H+06xy0i6To5AjixPOJsHcH6hg0JePBU /t/ThLcTWwraOaq+0VYdYIDA6cNEbkBESk0ElnOnLFwZYICHvLNI+kn4cv5+7cftlCXK3 taswyvhO5cSKQerOBVjL07yRimY6LGuUSiniGEfjwQASCpSsPqy9kNjLnoQqHIljyucOC CA0W2KYj7KNO6s5LmFDEiTJrElxDaRXTVw72suBV6qgdSYnBt9+ccg6rzClizIvkFyg2K /YyqgakPyp/T55k+Wq3Cp7dqVuFMGg3If2xl6UqeAMUgIa3b0iSvRG43v2THTCYS1ePhi 34/u4lbhMkP+qOlKbCDN2uc6/6j2vSJq2tIO7P/XqLq8oiaofa4RNsMPoLGbNR+C16r4p i1HPU6dIX0dmX6+eYEqVeu25TNWhAxScdbe7DrgYd0u0k80SLJnXaG0C55QTe74xWsWG0 H/b8WU2YbY6k9aHP6WV5QxgE4osiHvqgOvNTQBqHaVY/ry49SWwkKlRnmyWaiqng9kkWE x6EDrI8PqRT3qqYsJMpwSAmhqmWBhGq9D2aF3kaKwcb5baIPQ+uPDutTpl20eGFAEiSvL PKHKSGFRyZxkTuZYJRYu7xPaJO/0Zs/g4mlTGXXk/kaE52Eif2kwmSN29aUckYg=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1779188971; b=06S3+tc0mbeQVpuns0w1x9Vf1eDx13KgntpG0RTrUB3d9Hji28ggfED6Q0TFi4gYrNGp mOjm2mgoyUzd5Lrvc1kv7bSx8KDw+xyESuDP520+b4i2WMY4gY/hRHg3jQsUilVfTl5rl L4KPgeEYT95yeF0rjTEPvUhl5RlvgreBsR9fQJFlguGpgV80oUN6Oj9hru07uw3kbXDH2 iaooUuha/3M1mBQZb2eky9mrgLMdmFgk4dRdaV/MSQBPchMmlZSmNQfvH/u9pZMpFnPMw VR+6a25hNnG9vHLZLHhI+8HdrCziDs3xz/8PZ7pKoDXemepEsiAtzNPW+ESarWa2xdj7F YpF5+W/SEt7p0bu7DKJxtgRRPcQKiwI+kaYhgibfGSpZC3izWasajZs8/j/pX0cEz+P6A inV4ytMa/LmOWiA4yGtyhNN/gjasAni1Ieh/uet5n1+QFVLHCGHQ/hSDuMRxQB+uEhOry CYmOH61WsQKcVfuQs/fw0otmFAHVxR5SHpl8U414VJzsG/4pwV8pGExrmQhiqOvXlefYL V14bKHcbY86vI/BzAcv++QTi7w0wLsw7D7DYcR3Ndn68ZqJAIUID19alO+orZG8CZtqLl 3qmjdYL9PLxPuaR3zpbptcrS8Qsoqo2jDlbWjEFHbgpsu6sZ7D/02y3Lcpot+wc=
- Authentication-results: eu.smtp.expurgate.cloud; none
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 19 May 2026 11:09:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-05-19 13:03, Dmytro Prokopchuk1 wrote:
Hello Nicola,
On 5/19/26 13:45, Nicola Vetrini wrote:
On 2026-05-19 12:27, Dmytro Prokopchuk1 wrote:
Move XEN_TARGET_ARCH export into the architecture selection
branches instead of exporting the variable before assignment.
This ensures the selected architecture value is correctly
propagated.
Did you see a case where this is not correctly propagated? As far as I
I didn't see a case.
understand, the value of XEN_TARGET_ARCH seen by subprocesses is the
last value set for the variable, regardless of where the export
command
is placed.
Yes, you are right. It works in that way.
IMO, exporting empty variable looks strange...
Anyway up to you to judge if this patch is needed or not.
Indeed it is a bit strange. To avoid this we should perhaps move the
export after the if, so that it is obvious that it contains the correct
value
BR, Dmytro.
No functional changes.
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
automation/eclair_analysis/prepare.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/automation/eclair_analysis/prepare.sh b/automation/
eclair_analysis/prepare.sh
index e941e6edc4..fde83c2d2d 100755
--- a/automation/eclair_analysis/prepare.sh
+++ b/automation/eclair_analysis/prepare.sh
@@ -22,12 +22,10 @@ if [ $# -ne 1 ]; then
exit 1
fi
-export XEN_TARGET_ARCH
-
if [ "$1" = "X86_64" ]; then
- XEN_TARGET_ARCH=x86_64
+ export XEN_TARGET_ARCH=x86_64
elif [ "$1" = "ARM64" ]; then
- XEN_TARGET_ARCH=arm64
+ export XEN_TARGET_ARCH=arm64
else
fatal "Unknown configuration: $1"
fi
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
