[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 2/7] x86/hvm: Introduce hvm_emulate_one_ctxt
- To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 May 2026 11:54:47 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 May 2026 09:54:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.05.2026 15:13, Ross Lagerwall wrote:
> This is like hvm_emulate_one_insn() but takes an existing
> hvm_emulate_ctxt as a parameter. This will be needed to merge the
> instruction emulator and VMEXIT fast paths.
I'm yet to understand why this is necessary, but I'm afraid I don't consider
the name very descriptive. Even hvm_emulate_one_insn2() or
hvm_emulate_one_insn_ex() would come closer: You don't "emulate a context".
> --- a/xen/arch/x86/hvm/io.c
> +++ b/xen/arch/x86/hvm/io.c
> @@ -53,27 +53,32 @@ void send_timeoffset_req(unsigned long timeoff)
> bool hvm_emulate_one_insn(hvm_emulate_validate_t *validate, const char
> *descr)
> {
> struct hvm_emulate_ctxt ctxt;
> - int rc;
>
> hvm_emulate_init_once(&ctxt, validate, descr, guest_cpu_user_regs());
> + return hvm_emulate_one_ctxt(&ctxt);
> +}
>
> - switch ( rc = hvm_emulate_one(&ctxt, VIO_no_completion) )
> +bool hvm_emulate_one_ctxt(struct hvm_emulate_ctxt *ctxt)
> +{
> + int rc = hvm_emulate_one(ctxt, VIO_no_completion);
> +
> + switch ( rc )
> {
> case X86EMUL_UNHANDLEABLE:
> - hvm_dump_emulation_state(XENLOG_G_WARNING, ctxt.descr, &ctxt, rc);
> + hvm_dump_emulation_state(XENLOG_G_WARNING, ctxt->descr, ctxt, rc);
> return false;
>
> case X86EMUL_UNRECOGNIZED:
> - hvm_dump_emulation_state(XENLOG_G_WARNING, ctxt.descr, &ctxt, rc);
> + hvm_dump_emulation_state(XENLOG_G_WARNING, ctxt->descr, ctxt, rc);
> hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC);
> break;
These two lines were already touched by patch 1. Afaict leaving the change out
there will be fine, and hence will be overall less churn (plus following the
lines' histories will be one step shorter).
Jan
|
