Re: [PATCH v2 02/26] xen/riscv: Implement ARCH_PAGING_MEMPOOL

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 5/18/26 5:13 PM, Jan Beulich wrote:
> On 08.05.2026 16:43, Oleksii Kurochko wrote:
> > The p2m_freelist is used to allocate pages for the P2M. To initialize
> > this list, domain_p2m_set_allocation() may be called from construct_domU()
> > in the common Dom0less code, so RISC-V provides an implementation and
> > enables CONFIG_ARCH_PAGING_MEMPOOL unconditionally.
> >
> > Additionally, implement arch_{set,get}_paging_mempool_size(). They are
> > not directly used yet, but are required to support the
> > XEN_DOMCTL_{get,set}_paging_mempool_size hypercalls.
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> with ...
>
> > --- a/xen/arch/riscv/p2m.c
> > +++ b/xen/arch/riscv/p2m.c
> > @@ -1606,3 +1606,27 @@ struct page_info *get_page_from_gfn(struct domain *d, 
> > unsigned long gfn,
> >   
> >       return p2m_get_page_from_gfn(p2m_get_hostp2m(d), _gfn(gfn), t);
> >   }
> > +
> > +int arch_set_paging_mempool_size(struct domain *d, uint64_t size)
> > +{
> > +    unsigned long pages = PFN_DOWN(size);
> > +    int rc;
> > +
> > +    /* Non page-sized request or 32-bit overflow? */
> > +    if ( pfn_to_paddr(pages) != size )
> > +        return -EINVAL;
> > +
> > +    spin_lock(&d->arch.paging.lock);
> > +    rc = p2m_set_allocation(d, pages, true);
> > +    spin_unlock(&d->arch.paging.lock);
> > +
> > +    return rc;
> > +}
> > +
> > +/* Return the size of the pool, in bytes. */
> > +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size)
> > +{
> > +    *size =  pfn_to_paddr(ACCESS_ONCE(d->arch.paging.total_pages));
> ... the stray blank dropped from here. Will take care of this when committing.
I would be happy with that.

Thanks.

~ Oleksii