Re: [PATCH v3] arm: Fix PT_PT table descriptor value and comment

[Julien Grall <julien@xxxxxxx>]

Hi Gabriel,

For the future, when sending a new version, please create a new thread 
rather than in reply to the latest response.
On 18/05/2026 22:00, Gabriel Quintáns Souto wrote:
> Per ARMv7-A/ARMv8-A ARM, bits [11:2] of table descriptors are
> ignored by hardware. The original comment incorrectly described
> block/page descriptor fields which are not present in table
> descriptors.
Do you have more details why this change? Is this to strictly follow the 
Arm Arm?
In the ideal situation we should have the page table descriptors 
consistent between the assembly and the C version (see 
mfn_to_xen_entry()). They were diverging before and this is still 
diverging. If we are concerned about setting AF here, then we ought to 
modify the C versions as well.
It could be done separately though.

> Use the minimal valid encoding for table descriptors by setting
> PT_PT to 0x3.
>
> This updates both arm32 and arm64 for consistency.
> > Signed-off-by: Gabriel Quintáns Souto <gabi.qs.mail@xxxxxxxxx>

Reviewed-by: Julien Grall <julien@xxxxxxx>

Cheers,

--
Julien Grall