[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 6/6] xen/console: add conring buffer size alignment setting
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: dmukhin@xxxxxxxx
- Date: Fri, 8 May 2026 14:46:45 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njKxrDWggm0LIULwXaj5zpeN+aGOrSKm0rRA71M/V6g=; b=enmBK6sjhhNUXWcoLOOtttRONEjYToMqmSD5kL1bktzJO0J1AUIw0nEFXZJuR7XZ+uGtJ7F80w/+/WvSI9RBUR7Agx/+1j6eneUvQPHmOTbglIQq/iabNnMrIbKKI2oI0r630px3jiY216yUSbWLBKtqRMKqeZcxxy1v0f5MzZ0wRmHA89I/5rya3rT+FMWU0OjxEVGSu5QWipzv0yJf+8SlWb2Ab9z8wQXbVmboKeot38dHzweSiiuS6zrhTzJB9UfjdYOVZOp/6vTmgtu9yfA2AQyR/URGmpk2Jiye7ossD7CdF0KkYjsuZTfRMdgtIkJU3Zb9KselO/MSCYc8IQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GaEMrTJXgDUUAtsyqyrfW+v1VZfv58ohQTxDxS1VNKGVFytllDTkAbYxqyPKH+okFVhvuC7RRc56JlA02r14KewIdvYxY98NWQBKTAqiO8dg7FJk0YxZsnK4eBfKrMHE/4HE01+QiJQn58bORZHkBH8NQ7n0bhf0Ior5udgmq8W5+O633+KvAcFa/oUgEoDgfHyvokRZJ1PXXkwV03NJ93DCISJ+BAasVenGQ5slwukv0llD9qUG+OptRzPrkWunedZVu5cGx0ItVLklDuMqZ3xdzcfVYP13p1TGNYqASch8w37xIgwtJO8cPQQ1+qXu8SIy5J2yBtFEypZBXfsWNw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 08 May 2026 21:46:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
On Tue, Feb 10, 2026 at 04:10:42PM +0100, Jan Beulich wrote:
> On 05.02.2026 02:36, dmukhin@xxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > Introduce CONFIG_CONRING_ALIGN_PAGE_SIZE to control rounding down of the
> > user-defined conring buffer size.
>
> What's wrong with the rounding? The more that, with the original behavior
> properly restored in patch 5, it'll be a power-of-2 multiple of PAGE_SIZE
> anyway?
>
> > Also, update the logline reporting the final conring buffer size to report
> > bytes instead of kilobytes, since the user-defined size may not necessarily
> > be kilobyte-alined.
>
> Yet making the number harder to grok.
>
> > Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Having talked to him, I don't think he meant what you're doing here. All he
> apparently meant is to stop using alloc_*heap_pages(), which needlessly
> supplies order-aligned memory.
Thanks, I will drop that patch.
--
Denis
|
