[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] x86/svm: Don't toggle local event delivery on stgi/clgi
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Thu, 7 May 2026 14:08:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mnm+yObtMeIg91hRA0bU8O3aLhLSlsKNRkfmBP3+Ty4=; b=l6k5BOjUvGMoLY5x4OzkfUqs+g8WsbshPz5g09l9JICLntDHWBpbxGRfVKNqgeJCkf/6VcMdm6zasZSv6V9U1mq2pozgLy7H+R9+Ymo9vUP9fgr1yQbEzpuMINO2URDRlYjf4KcT9gugf++abTY+u8NZDKPjKfniAK8PQYtyAYNNGB06vcQ5Q8dId6Ya3LrKjo0bf0B1k2Wl5qSiiao/rxG3r1k+eesg1mCChi+XUN8/RcTdbjl5y9AOzRI2RFDBCZUK5Fm0Jv6ifeYtbwFffFkq+59scptoXEqr5PXujD/GrHSCq2EoF0xxTB/rcBmFisA9/DcUvChrw4vi2SZFZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qu2DTZCO7KJfdj5oQWNDQy00HYTW7en0yT4DR8Z/TDVw6e5SDx/0d/k3u8Ti+eG8ZWdITbeXRuVgd+l58RV5P+GwdS9s5kqIvC+Q9OKlz4oHFYPvUe/HSfCWCBSniwPQzqvYjBIdd1YaRsRgiCJeh1FOmm/Purya+EvbQIZhv7L1US60k1qIZozFA9t9c/SgZX7oIP7v+xRoZ8fxSRm/mzaT/1Par/jadoQqIvg8GcudUAr9iTSI9Ki27lcyClB75j0jibUb+inQEYG1HA5peIDDr8f5brTJQogEZ8//w2F70LnuUnAMZ3shAT6g6cwxlcIxbcqauWx2OcnDwP73pQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Thu, 07 May 2026 13:09:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/7/26 12:28 PM, Andrew Cooper wrote:
On 07/05/2026 11:55 am, Ross Lagerwall wrote:
There is no need to explicitly enable/disable local event delivery on
While the name of the function is local event, I think this needs to
state evtchn because "events" have a separate meaning in this area on x86.
Personally, I'd phrase it more sternly. The masking (or not) of evtchn
has nothing to do with GIF/IF.
stgi/clgi since HVM event delivery already takes into account the state
STGI/CLGI.
OK. How about this instead?
x86/svm: Don't mask/unmask evtchns on CLGI/STGI
Whether or not evtchns are masked or unmasked has nothing to do with the
state of the GIF/IF. Therefore, do not toggle the evtchn mask on
STGI/CLGI - HVM event delivery already takes into account the state of
the GIF/IF. This ensures the behaviour is consistent regardless of
whether vGIF is used.
Fold the functions into the callers since they are now only a single
assignment.
Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
|
