Re: [PATCH v4 04/11] xen: introduce domain-layout.h with common domain_use_host_layout()

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

Hello Luca,

On 4/29/26 5:10 PM, Luca Fancellu wrote:
> > diff --git a/xen/common/device-tree/domain-build.c 
> > b/xen/common/device-tree/domain-build.c
> > index c51520ebadf9..6949203dacdc 100644
> > --- a/xen/common/device-tree/domain-build.c
> > +++ b/xen/common/device-tree/domain-build.c
> > @@ -1,6 +1,7 @@
> > /* SPDX-License-Identifier: GPL-2.0-only */
> >
> > #include <xen/bootinfo.h>
> > +#include <xen/domain-layout.h>
> > #include <xen/fdt-domain-build.h>
> > #include <xen/init.h>
> > #include <xen/lib.h>
> > diff --git a/xen/include/xen/domain-layout.h b/xen/include/xen/domain-layout.h
> > new file mode 100644
> > index 000000000000..0532a27b44ce
> > --- /dev/null
> > +++ b/xen/include/xen/domain-layout.h
> New files should have SPDX tag
I will add:
  /* SPDX-License-Identifier: GPL-2.0-only */

> > @@ -0,0 +1,27 @@
> > +#ifndef __XEN_DOMAIN_LAYOUT_H__
> > +#define __XEN_DOMAIN_LAYOUT_H__
> I think this include guard doesn’t satisfy the coding style:
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=CODING_STYLE;h=aae5a47ac20345978b3c465b9d85f1d5f6774731;hb=refs/heads/staging#l167
Will rename to XEN_DOMAIN_LAYOUT_H.

> Apart from this, the rest looks ok to me, after fixing the above I will leave 
> my R-by
Thanks for review.

~ Oleksii