[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/11] xen: arm: fix len type for guest copy functions
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 5 May 2026 08:27:51 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uph7Gb0cdNhliHJ085f/SvQ437L6B+bXLdooKxlZok8=; b=RZQ2BeKYzVKxZPhCn6iwVNYpZTpQLik6p4V7Lw3OMnqOFzeneYEIX7ez2fNa/nfsD2r1moiNvYsioVlSvNKQZrExS6RKRH3M0EYIWJQXYke/HblubC4UBJEh0ZH5cYSHGalOFhB9CXvBKDoiuqY2bGh3FPW77qI13quRsd0iKDFXSs/AfXkBGme6iNOo3pTF+peZb5LXDILQOpaUmUnaWuHjdKHQRp5Cif5CSyND+vL5Ph+/OOi5BDAICYc++9qKxFMvlNrFeQ3l/mCjNyod1TtbWqIl9y3uI2vyyUKOT+fYGyAPsbqZ3oE+N0rA1lfheg3dMoGuftVj/ppvks1kUA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uph7Gb0cdNhliHJ085f/SvQ437L6B+bXLdooKxlZok8=; b=ACuc6b6bNJZAyOANvWY4wRkRqUkHIEIwEOgJgQXGOsjd9ERpweoTC4RK54YuJsw0KwzSQFpuvbVi2G7F6/xmx+RLGj2pZREqUnZJJUL6BDOITN6WUkRJnNkENBfHiMtpNDD5Tlmmhko9iPAYyx/d5sUeouh5AXJLb78VAcgzfGnXGoXS1ba+O5ESQi6O4IhKSyw5psKPbUKewAX3zgq9OCzyoOWKltoYnWyiAFX+bEG809CkcHc4KPRydxlZETsKNh68fHgwCLYNmBticcmHsVaoFBSVwePCOJudTfRZF7UrDJXjQze8jBzN7vq5+ecYEG87ZdGYC17Kq93g+bkXxQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=HP7CsRbg0ElU8DUxJv8A2RM886cZuCigGXzppC023C7VusyxUlnE9AGNPAm71PvjYaB1nQh6Yi6muhxKa3Oy2e771vYsB9HJzI9QP85LV812MRTtf98DyJ9p6ebDjNOk9vXfB+8WLhdSwtolEwAXaKxLHWbc5JBBA1OPROBGhSjf9Bzmk12xObfDphVl0LfgU5tYcmUbc04i+n0SDaHkQ5PEGcZAKFuhJZrPdKbHHpmmCcNUliLhbLIjAfnIlMmneLtzANaFIeVGq7STeUiaS0f8LGca4/AN/HeILbZf1Qgo3YHx6MHOzbBW8Hm20mlTP7SzYJnVXTpwZxYXPVdlpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZFX2h76rSP9XivF5IOy/vmgoAC0CpcHpQ2Dfb+egUo7a73rlPPKGfTXNUGXzYRn3X59Jhq2u9GQPF/4N2ryeRfsiD62TuUh/H9Q/2+TlRG/MibVuBPjBgQ+B5891cD1Ez5ScTiofG/pl7mE++wYKAcTw7CXpkxk32wm1foRAWul2v6tS//grybteHqPLx9i2zqEfqtsVRbMRb7ByaPqabchuYwliJAny5qO8qZybDE5l7kB+3Hsd7azqiG5ntwwUZ0Xst8pMuj6qfZvGsWuOXPGsc9eZbHetxnxnobz0WSE5/WI2CPjLWg7s6chy1k2XOqBFm0Ymb11gGUtMH1kwwg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Tue, 05 May 2026 08:29:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc1xwXYYBcuLui0UypBKVcqnkF/bX10fCAgAeOAYCAAcPSgA==
- Thread-topic: [PATCH v4 01/11] xen: arm: fix len type for guest copy functions
Hi Jan,
> On 4 May 2026, at 06:30, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 29.04.2026 12:08, Luca Fancellu wrote:
>>> @@ -136,7 +136,7 @@ unsigned long raw_copy_from_guest(void *to, const void
>>> __user *from,
>>> unsigned long copy_to_guest_phys_flush_dcache(struct domain *d,
>>> paddr_t gpa,
>>> void *buf,
>>> - unsigned int len)
>>> + unsigned long len)
>>> {
>>
>> Now that we do this, potentially we could have truncation in the places
>> where we store its return value
>> inside an int:
>
> Those would suffer from truncation before and after this change, wouldn't
> they?
> Just that where the truncation occurs does move. I.e. if necessary they would
> want dealing with separately.
yes that’s true, truncation was already there in different places, do you want
to deal with it separately so that
we have a Fixes tag for it?
Cheers,
Luca
|
