[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/23] xen/arm: vIOMMU: add generic vIOMMU framework
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Milan Djokic <milan_djokic@xxxxxxxx>
- Date: Sun, 3 May 2026 12:38:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MOiPT3jRF1eMPh/hdxWJHGEFbDNmd8Of8OktvXY2qu4=; b=FwMRFRoL7/xqIyTJvdH3/ZCTVtRC+8GLEnkSByUJNMwFWORfn3pOWWaP+H7e5Nvib6rTB0WHZnzYcQj5NEKGP2S5vdn+UeEgD9nSC3xf06c7QlGgtMNZHozo7yc/sIBnA437Kl+6u+WbkMYvspGRj6/3L5hq9H/BRlJFJkPthgAtq31AaavvebkKXkMqEP/rUHWe1L+Jl1Tc138VBkOCMvVn5C6cQ1lmWkB8mGxywD86rXyL8WbJ1fqq+xlMBYIUsaYaN0sgpdx5OBuUskl6dvdSRKOQknOUtVlVt/EiAq9/f6Wkh6GP3f9iKR9kkgKz/tsxtu40tBD+dyEDavg+aQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mMfFRqoqGHLB6yzkJ1vg2m3Cg3gAsz+4Fj8sPNkKnm+Z13SMGZWY+V5y7Z9oXmH3Eyt7eTeb6XKkOVaKSUFd4jxJAZIIWjhmwH3Mn61eUGZV8w+7TCneypa42uv6giO3YTr09EOIl8f8WgxPl1ZzZhRVwSb+ucYAXMNoIZ95ABrbdImEi6yO2ZgvGtcOmrgwv8kZMVZW55lzsGyvaLoCfe3OUzQOeBBSb3f3Ggw6uBzX4UB3fi3SS+P9/1SQum0E7yACQM/h7eUYK72EFGxZqBTnqRwhDAFL6JT58mY5qTRfvEfK9YD+GbFrCS7lcmHtecwsXTJYt+WqwXVIZPXgjw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Sun, 03 May 2026 10:39:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Luca,
On 4/10/26 13:39, Luca Fancellu wrote:
HI Milan,
apologies I missed one bit in this patch
@@ -721,6 +745,9 @@ int arch_domain_create(struct domain *d,
if ( (rc = sci_domain_init(d, config)) != 0 )
goto fail;
+ if ( (rc = domain_viommu_init(d, config->arch.viommu_type)) != 0 )
+ goto fail;
+
Here if this fails, we call arch_domain_destroy(), however in that function we
don’t call
viommu_relinquish_resources()
Yes, this is missing. I will add it in the updated version.
Cheers,
Luca
BR,
Milan
|
