[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/pdx: Undef the correct macro


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Fri, 1 May 2026 08:42:46 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=citrix.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z+eL7sx16NpzAMervcue5ZnImAY2o0Ceg+QcxkJy/Lo=; b=dRmDDJ46aAoChwlyg2W39X6Al668h3AS78UXja6RFYBGHin2SczsSc9j84FF5/6qJxd9Cs8iv3cHNCmi9XAyz0zubU5zj+7a/ug+6ZPQ5FPBJhPA56vX/AumIOjC6LPtsDX4hXpyj12DQsF0Kcl/voRkAaahiEPNMXsJ/+wprp0S2WqgE62G+r6HWdgF85WUqNVhTFDTjWJVKtzJhn6NQX/mg6gzkocXPLue6bkbNXYh7i6J8dpVOfAiWaZIskwV7+Yt98EsYo0laTyzMl1hrCAGRieWcBYoyt4xgazEXAn7q3uiCHccKByW9/bKnJMshVsFd4cPkdv3bOE6+ku+rw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z+eL7sx16NpzAMervcue5ZnImAY2o0Ceg+QcxkJy/Lo=; b=gUj5G6JKT6RvPa8DjK7WbBuu9N9k+6i29iUxyuF+hVjrl5ihVeGcb5b0yqw4Ukcpw4EjeQXTRDewsG7r6JJ2Twt7NJYXE2G18boB+/P0x4AKuoKToeZtKzy1Tk7DIohhiffT+PSpW1dLtZlJqNg5uiad4/Gw2g1fHlhuKafaXYB7r7FmVKieBrBxzh7pFe3zV6MUeyLqe/db1s9v8l/voSloFboZEOVhIBIVfNrd5POVb6sx1HSFGo0Y/0bzji/qyTj3vGWXvCf6061essROJzpynT/0w07McFMzbkILl/ocZRwlD/YqSFc7Li1r3FwPLXZHZibZKvuMuokmdf2eNg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=HLbphWxRyBDSdDmrhd0VIcZHcPT7+O3r36+wW2B2dulJh+tlGCORdY+E+rhU/Oxpj7Wk6jsGcXeySSnt217sJHoEh2d1yQDh0YLy7YWb5FHZAvdlMhOBENQzZ6OrDuIOHlTyK7ZRUSiWQ8dVPxn61Q2FOPgmPpxLGu3lwxVJlAYl2CiMSucIkpkg8b8NEcRTGAFTbZ2JKNUpamC2l8U7p0j8ipzCx+9bmrEZbXA32LDK5NNc/a9/gKKMfQRsNA729UP851lXA/SkRRd6ky6JG//v2hAnnjQbFvK+XCkNr4Qvku2wcKhfFC4WvVzUOxlySBI18y6CedlEhj2MIA8irA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GbArLqmy6ON+skh/ugL2rc8Yd5Z+Oa8R8GQT55A4NqXc2Ow/5a7gKP24gbZ6UIZ8UbtewVRpV4k1Yv4L1TZePkeQozRpjxY57mAgrzF62MWN/XNjIx0vPEEmoTikv4pkWyVF7j9O6V0i/tQq5iletf+cnqbDOUANVQ31CJPZAP7TE50m3GxKFfA0yxKfIDUSGACGL9H4+cOfdYqZl5+T9cf5vRtMphXwFkV5U0bR/2QWkQrNq5ARTMs9uP0hYbYGIs66PBxhbkf0KblS2K/iUtEiCg5tqfLfGr7TPv31pq1Cdvqmm9zmnDwU6wHY/W1CYEBaPCAbMCSoeop6R1M4tg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Delivery-date: Fri, 01 May 2026 08:44:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Thread-index: AQHc2UYqbfaUw2RH2EuVGUbnBMCcnLX42kcA
  • Thread-topic: [PATCH] x86/pdx: Undef the correct macro

Hi Andrew,

> On 1 May 2026, at 09:40, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> 
> This was caused by a renamne during review.

NIT: Typo s/renamne/rename/

> 
> No functional change.
> 
> Reported-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Fixes: bd0b3a876d80 ("pdx: allow per-arch optimization of PDX conversion 
> helpers")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Teddy Astie <teddy.astie@xxxxxxxxxx>
> CC: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> xen/arch/x86/include/asm/pdx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/include/asm/pdx.h b/xen/arch/x86/include/asm/pdx.h
> index 6be7e1185eb1..6c10234ecfa9 100644
> --- a/xen/arch/x86/include/asm/pdx.h
> +++ b/xen/arch/x86/include/asm/pdx.h
> @@ -57,7 +57,7 @@ static inline paddr_t directmapoff_to_maddr(unsigned long 
> offset)
>     return offset;
> }
> 
> -#undef PDX_ASM_GOTO_SKIP
> +#undef PDX_ASM_GOTO
> 
> #endif /* X86_PDX_H */
> 
> -- 
> 2.39.5
> 

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Cheers,
Luca


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.