[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86/cpu: identify uninitialized CPU data using BAD_APICID
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Thu, 30 Apr 2026 13:46:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GA0I+u7PVwRVBZ78yAc4QDA2zYRbNwF4+FJE2Bq+94I=; b=OKfmQsJJ8WRvsasonebuXWdXXNTnocJGq9AQu1tKFwb1juP5AZAlH1DZpamk/hhD+2xSVDdQ3H3wm1cZCdewvWlfaoKSrJeDnaCzKQw3/OxVdJ2pMq+gRI7UTwNBFpm6uhaLjLlmxjgNFHWVL1Vb+vLPRvPH2ZoeKgU+IHyD4Bsphrlr6xsisa4c1MKFvsZceNlBrakJqC9eGD137RBZt8X9/hVFLlf8Q6zMnvFEguVhlJ2BnMKAvJr4LSpefUXn+SVObVHLfrqOcXtIJNjgoRmcrlPo+qjUUYNkZpomYJNoJa+s5aZhgyOcPbmT+4rzTuqOLVqvRqiS6EPoowDkhQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DkuXLB01deW4cPfURSauhuLNTRO8UX8AXkPXi7udS5kAFhrlT3D5eNhp+nqnbXmDHuTlG2k5fVriMqOgZbmKvIyCSS7qyBKaTlr4froz7V5eN+CUe6Yqj13aiNrnSEdvcQetHrHE7s9ZCEhkXjTR6b2wL2fIdNlkWClpMsBQebDqKcBJhWjh2b3Wym6MfyJqKTcXyYQ+b5fa7C0TEV8NHAZ4go02urjQN0qm8qY50Bod5zco6qNrKs05yGr47yWTNn+AxUa8sILCvJDn5nKJrombbfjd0qfAbZZ0NzuOC6MunEPiiMMVkdVclNtDRuubn/EsFEBY4I0rB5s3/BwQdQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Thu, 30 Apr 2026 11:47:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Uninitialized cpu_data[] entries have the apicid field set to BAD_APICID,
not boot_cpu_data.apicid. Fix the check in cpu_smpboot_free() to use the
correct condition.
Fixes: 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]")
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
xen/arch/x86/smpboot.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index 491cbbba33ae..ff05955bae40 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -961,8 +961,7 @@ static void cpu_smpboot_free(unsigned int cpu, bool remove)
* In that case the socket number cannot be relied upon, but the respective
* socket_cpumask[] slot also wouldn't have been set.
*/
- if ( c[cpu].apicid != boot_cpu_data.apicid &&
- cpumask_empty(socket_cpumask[socket]) )
+ if ( c[cpu].apicid != BAD_APICID && cpumask_empty(socket_cpumask[socket]) )
{
xfree(socket_cpumask[socket]);
socket_cpumask[socket] = NULL;
--
2.53.0
|
