[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hypfs: remove unreachable statement in the 'hypfs_get_entry_rel()'
- To: Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Tue, 28 Apr 2026 13:21:49 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HvU6MtZJZYtq11B+jLckyBEof32K8q1k6vrQLP49FB8=; b=xMGPvoxRfIcleR+q6hgPwUKIHb0BNN0jpHx4J4CmAzPd6hjynGvMLKRxrDO0RHDchHkWi7Hl4M2kb8+CHSJu0/3TkOFroVJSvre8PByYAR9UvQ3zRE6g5glCh0SIQL8FOKH9StovrHiXcZR54jOTTUYVwNmPPibIP0cxWP8Nid1n4cRrY3SP/LFPzNLJFSWctpAS3/lHMoC74JiNLhgV22RxkrZp4s0+pF2/2Kx0xFxhQaxIrGynrW7ukk9Hyj4bDjFatwDZ3Aplhs0ALjf/3dUzdr4ZE3NCrFCly6bBACeqdZ007t50nP32gQL9oJKB3w5AaUdWfFa/RM9PAAy1dQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FF7tagXKDG4WYWXZErORG29LrusMfiGqhca8h7ev0L8sMyCJy0cg1JzbVr5OeAQQPNCKaz6qRGiWzHzHyeIWaEj5i6xTxCq69nNHMUJMDI3bEH5sYqY2LU+mjh0msGv10dX14gUS5hSV6nAoFKwzsXXeQqT/J8+yIwzMegz3qga7evKrSY2/PHBdtJRMR/RGzpash+NPLWd/Gv6NPVr/BuQPNRdJ/SB63P6o7V32fqaTiyDhe6/k7we1f6Y+y3xRYgpE245vLmzR99YHqaggoJ347IXMy53M/8JBwh2X/4xhMxADKU3Wh5ev60lhBSE9WT3FqbCVSBnunzCTVTp+9g==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 28 Apr 2026 13:21:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcyDlVyOevPxMGvE2K9zY95LxHD7XhYbqAgBMxwgA=
- Thread-topic: [PATCH] hypfs: remove unreachable statement in the 'hypfs_get_entry_rel()'
On 4/16/26 11:14, Jan Beulich wrote:
> On 09.04.2026 17:55, Dmytro Prokopchuk1 wrote:
>> --- a/xen/common/hypfs.c
>> +++ b/xen/common/hypfs.c
>> @@ -347,8 +347,6 @@ static struct hypfs_entry *hypfs_get_entry_rel(struct
>> hypfs_entry_dir *dir,
>> path = end + 1;
>> dir = container_of(entry, struct hypfs_entry_dir, e);
>> }
>> -
>> - return ERR_PTR(-ENOENT);
>> }
>
> How certain are we that no supported compiler in any mode of compilation might
> issue a diagnostic for the then missing "return" at the end of a function
> returning non-void? Imo we might be better off adding ASSERT_UNREACHABLE() and
> keeping the "return" that's there.
You have a good point. While I don't think modern compilers are naive
enough to miss this, but I completely agree with you that being explicit
with ASSERT_UNREACHABLE() is better approach. I'll update the patch.
BR, Dmytro.
>
> Jan
|
