[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/dt-overlay: support phandle-based targeting in overlay_get_nodes_info
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 28 Apr 2026 08:05:34 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8TvU1uWUvq40iIuRGu+7+Arbt4KrRaG+uvclWK2hGHQ=; b=LhFk+cl4rGuyWiR7kTzoO+KxyIhDZx8ZdGi/n4TSSdwR5b5R2Vom9xO9gJyOqFjqqxr2X/UiUQ1JROLo7E7KlwHhHSjoL31iXRbmqNNj2H0wIa1+ieaobckAezypYG/363oSUje8q4B4p96daAz8/oQT7hNGzRTA4Ifgx37ynutwE6TK+ayf/a9cFEnhhaQasQDGVZcyHir5umJGCe+sDycteS3K4XOychkzLfAWE3DAnhSQq0d/0F3ig5pTmySwXgcp+WIx3eXkxIRWzIOL2n77LKKpAANStLhUhzTs610Gb991A82JtkxyhIXI+vCV6m3odnaxyinyEGimC0FgAA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8TvU1uWUvq40iIuRGu+7+Arbt4KrRaG+uvclWK2hGHQ=; b=fkrzvYZuv+yMJjUVzQIS7vcNjTBPIYLJYmbYubIgITSYMTgXncTDiOp/4MNjXUyBBj9SiXgnGoc7k6yJnT+rQfCtDJ72zUaZGa6cLTqWEekPs4xSDBp91qARId/XTrOQ6FTnrG9a7eA9YDHzYaS0k0prlU/qfbDqRlh1V0B9Xg6BOum7aS4xbC9E0VFuKCXmiu7I+hlTx0HBqVwVOqPp+WzfDcfeUY8ioQM0/iEp1lGginnUuSGJgfyOmWHiHyzOEmuosnTCwjmmxjALuehw2T3l/UwPSPI+mnM+27NqTeepGgYoCiNYZIQe5JUQx1Ko6IHQnr6G7p8+en+rChbF2w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=O4F/W7oV58Qw9R/iNX/3QAX2vCDZVuGT8wvC7JT+WBsTvIrqNUD+TXvVRQOJKlcJg38Lmf+ABpl8xzawNUHR1ARRFL4GzK1doK5ZdLJQcUPziQurc8dO9LT8ykDnXUHqNk60V0mNUFu2nrtaoC7+7vGQ5fYvzsK8oMu+2w9kqhn7AtmzS20iBqpbvGpIIFez8UihZ1QTw4dG3xoC9u6/pExus17XD9FYcXpr6+iJHw4XcWoFtzypl/8BQAarThaVSTaKV/+KnG+nmDAo7l3JYYN/Lpg3/qTXUrhkBM1kpkiBdZQvsXFACLbiePRLTU8TU0pB5qplcYPpw6d8cC6apQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o4P6McHCG+eYw6qPAJTbq3rK2ez7zRoUrCtbK3m8Y71Py8xUhjc0qX6/tSdwhiVDZqsbizD9/HY4Dqnx88ZpCWinuGPKa/2a6uVpP3nIZZNrj+eCUHdtQuuN95CnorzfcMjLnkY5TTfvv9LkZFfpMvrV7uI2HjFmoH2H2cgNNaexy5lNh9Qs9AOfa9/TE/n6qJyw5xaaNhgsaMUmkheiTGUQmBVO6ee43LEB4YfC3V2UVn6sSRRxOdP4EMBTIjOu+eA3wneAp+tNI08Ow+6zgpiT0Zph1CqyY4RCk42T41K0/y+WiX7mpfz8mW9GTvtFqf6d8dQK+kXhMu3sOseHog==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 28 Apr 2026 08:06:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc1uViFjC75IOoe0On2+u4z8CzhrX0HacA
- Thread-topic: [PATCH v2] xen/dt-overlay: support phandle-based targeting in overlay_get_nodes_info
> On 28 Apr 2026, at 09:02, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> overlay_get_nodes_info() is called before fdt_overlay_apply() to extract
> target paths from the overlay. This fails for overlays using phandle-based
> targeting (target = <&label>) because DTC compiles these as unresolved
> fixups (target = <0xffffffff>), causing fdt_overlay_target_offset() to
> return -FDT_ERR_BADPHANDLE. Prior to this change users were forced to
> manually modify the dtbo (even for hwdom) to switch from target to
> target-phandle by manually inspecting also the host DTB.
>
> Introduce overlay_get_target_path() which directly handles the two
> targeting cases that occur before fixup resolution:
> - target-path: the string property is returned directly.
> - target = <&label>: the label is found in the overlay's __fixups__
> node, then resolved to a path via the base DTB's __symbols__ node.
>
> Libfdt fdt_for_each_property_offset() violates MISRA R20.7. Despite
> libfdt being excluded from the analysis, this causes ECLAIR scan to
> report a regression because the violation introduced by a macro is
> reported at the call site. Deviate R20.7 for libfdt.h.
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
NIT: shouldn’t these be in chronological order?
Cheers,
Luca
|
