[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 10/13] xen/arm: Resume memory management on Xen resume
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 27 Apr 2026 14:50:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Id1XX/7OPoW70pEXSKEcjuXma5hQPyIU4q01hyPib7A=; b=Fe/YBAYly0hfJwvuhzDJPldSgPPlalaTWCC5q5h7nhyIAIUpgap8SpSErzjFlpw8WGjgLvhEYMG5B2aOeXVN1dUYpueY2GAKG39aGTonR24hfpYkRoy0jAYFttA5mgeqAlj6QoRMVfk8TSKZksCdRE2fdqmgJHzyZ3W/XjMWPq1cur3VT76OPt5Btiv3orSlWsFgemloNVYukSoUb3RMHTjrZAjPM0EEZaOXSmzX6sZa3X+WXc5ohBTkDzpdck+IYDpmNtqsPRBHeaR0AI3G2w1GHphwePq31k0pc5Mf1TrqqtdaKHbd6dT1Yl3w6itBKq8ctRWXhXtoMS7EpguIJw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Id1XX/7OPoW70pEXSKEcjuXma5hQPyIU4q01hyPib7A=; b=B607JLDunv2du3vaIakznLbLgd9jkpZfBhA803MpReBb+sBqVQsny+LH2qUCmgZ9sbKo2RZlzRLO1MxMBXTccFfv53cuDY6hryft20mX3FGNsLDEo377m5c0vaWSNBWDFsnHsMqRaMwa/EX6LG7a/7tDAulVqkPwbkFhdxO3vuON6duUsTMqBuk5P5TA6oA+H2cTkrelRqi8CwlaBW9UcGQcpVjxE93CeA4nnzJRvCs8iJXD8CXdvEe/67NFN5CMpGOf7cZYDbowOctHkAFI4UZlzG84SPj+JCl020RHclHTxX58Hewgj3ryWJ+BtwdfvR4Ht+DTN0gSp/Q06rh8fA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=nuXJkp2BQRN1uV9VZnZWaBeZtnwuT15LJyDp+khBk8h3dcZSbh/amXMc+8F4noebaYMU9AOq2E4rraUBwdC0pS9g+2s7qhGUppVZbjFveeA8NrFRIS9Epa1Ej8RcjEE1U8VwKm1PKbQh8bkDCV9O4OyxdWtGUWch39MVCHjD71/CMxRBie6jOpd7nJ70MLnjPFGYbHozWnSX63LhWvJEyZNchcJxbiby8ed4uYPrhxlpiSqGW9XNLskzi+uP5HDdZs2W7TfYwQcwGmM35HA0dDEDwPsgwuU6GcUUIG+6R69R71GRuJX21DV51AzSpFZXhU6sS147fzJvN7/vtMvAkg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ROW3C6f/JCzNYIrFvJOlGh1aCtFM2IDR7Oc7vSHzOFU1Y9E6kR9fp9iMbEsd43OuOZ5j1V0id86Kz7a2VB97hA1beCvuFEJv5QqhakY1RwlJcjpbPteMSQGyISTrtik3WTe02vrIpNs0gb93FlREnKMSuua8z0FPHG4gIk88YIoMmlMeSIuVSjgsg4svgFU3TM174o25D+xfX0I9le03kPvNCr005JvlvG6hps8hhtFiKLG8q3SK9rFeqljyhh1VaqW1H1DTfXJlwKY09rubSgclcN+JQPumX3dnHpHvqZ5GKGJ0seWiKgODKlYA3quRZm1GXhZlq1+mCe+jK8r7EQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 27 Apr 2026 14:51:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc1lUhIk7A8CPopkGFdHGIM/WlPw==
- Thread-topic: [PATCH v8 10/13] xen/arm: Resume memory management on Xen resume
Hi Mykola,
> On 2 Apr 2026, at 11:45, Mykola Kvach <xakep.amatop@xxxxxxxxx> wrote:
>
> From: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
>
> The MMU must be enabled during the resume path before restoring context,
> as virtual addresses are used to access the saved context data.
>
> This patch adds MMU setup during resume by reusing the existing
> enable_secondary_cpu_mm function, which enables data cache and the MMU.
I don’t understand where this last part happen in this commit:
> Before the MMU is enabled, the content of TTBR0_EL2 is changed to point
> to init_ttbr (page tables used at runtime).
>
> Signed-off-by: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
> Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xxxxxxxxxx>
> Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> ---
> Changes in v7:
> - no functional changes, just moved commit
> ---
> xen/arch/arm/arm64/head.S | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 72c7b24498..596e960152 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -561,6 +561,30 @@ END(efi_xen_start)
>
> #endif /* CONFIG_ARM_EFI */
>
> +#ifdef CONFIG_SYSTEM_SUSPEND
> +
> +FUNC(hyp_resume)
I think we should mask all exceptions here:
msr DAIFSet, 0xf
until we resume correctly the status (VBAR_EL2, etc).
> + /* Initialize the UART if earlyprintk has been enabled. */
> +#ifdef CONFIG_EARLY_PRINTK
> + bl init_uart
> +#endif
> + PRINT_ID("- Xen resuming -\r\n")
> +
> + bl check_cpu_mode
> + bl cpu_init
> +
> + ldr x0, =start
> + adr x20, start /* x20 := paddr (start) */
> + sub x20, x20, x0 /* x20 := phys-offset */
> + ldr lr, =mmu_resumed
> + b enable_secondary_cpu_mm
> +
> +mmu_resumed:
> + b .
> +END(hyp_resume)
> +
> +#endif /* CONFIG_SYSTEM_SUSPEND */
> +
> /*
> * Local variables:
> * mode: ASM
>
This is more a trampoline for the core resuming, not sure if it could be better
to squash this
into the following patch, the maintainer could provide their preference.
Cheers,
Luca
|
