[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] arm/gicv3: Decode cacheability fields before comparing
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 27 Apr 2026 11:29:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WDg9CJhuPiqxLjSHwdb9K9pncKzpK44pSkYsiPh/VmY=; b=u6aWXzDJUxX4oxUXPn3XtbjN0OJc2oZ5tE7YO6vIjk+lxFWWbMrInpyNfPCSqV98Vzm54MjvIdsTCyUEUklMFyAudfpkBeUVJ1rQS/UNrGU1iVR72XH5zwoNPOlOFhAumukFicBuZ84dR2bBQCqZMqWs1pphrIMAQm+tvn7DVWnh/1wf64SGfREobfy/9UJZKwQJSD8+CQacXczaAZ8cUe71O9ynSYT+fsLW2RSV83Ox4l5SMeynyTYeO+lw9Hok6EtZCq4Pam+AFxtsz6LZ+m/UdJelG/upuh4s3tqGRwQY14nfUYTBApLM9IhBJkewR/Uu8bWAAozuH+WAaQnCJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ERFeo0BiUTzwTXP3UXlTnqv6n1McIMvYhmRlYuJpNaGAyXnAs1spsceDKKr1QUtXhnU27u/oEpo1KrMZRfCmrh/6H9JfTx+4Oi+8olGrHe2FDZxQuHgmwGtK1tSOT7f44KZ3+sczwDn0y32sU6gEerGqjqUP2q2mYEELQPgeHhwu8VnWvnzBHQqU8TbnSBtUFWOKgpKLnotYmKrcEUuc8zTWMeE4uGD8ed7fCQsm2jUXTw/feXpKktMJ3jqY2xszqNo3gEa+5vJff9JinEExvuNT8/G/6JN45Zlz9QMQWVUBbv5PuSXlhi49irSFtP9MlyOI2LAH1p1VRzbCCOa8Mg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Mykyta Poturai <mykyta_poturai@xxxxxxxx>
- Delivery-date: Mon, 27 Apr 2026 09:30:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27-Apr-26 10:37 AM, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> GITS_BASER_INNER_CACHEABILITY_MASK and
> GICR_PROPBASER_INNER_CACHEABILITY_MASK are shifted masks. Comparing the
> masked but unshifted values against GIC_BASER_CACHE_nC, which is an
> unshifted enum value, leads to incorrect detection of non-cacheable
> GITS_BASER tables and GICR_PROPBASER mappings.
>
> Use MASK_EXTR() to decode these cacheability fields before comparing
> against GIC_BASER_CACHE_nC, so the backing memory is flushed when
> required.
>
> Fixes: 05238012b86d ("ARM: GICv3 ITS: allocate device and collection table")
> Fixes: c9b939863c89 ("ARM: GICv3: allocate LPI pending and property table")
> Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
