[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] xen: introduce CONFIG_HAS_DOMAIN_TYPE
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 27 Apr 2026 11:21:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rDRa2YENjPiUPVFKF9FwQEopV3rjTG+wNc0PT4Bgb1U=; b=myFEwoLCygfLIawrUOiDlrdFphHbhXwC1y0Kxl+FqZCDM5TK0MIuYzP9LY/2szQK2jzoyRna5WME6KS6Ni7MomHaztQSyaxfYdAtaXgCFuYAvQ8Z9FDAgR5Ryqfbg7Yzx01+0sZiOQMTfgKX2qFCbC7N3fabGVNjqaJvhBfFktGK9axmF+tOrxUVG/IfhSgSoCGZJdEoQDSw8SJtCxlrf6tMPDyKFLY3mxlOvgLR5hRVNJY5PMBitE6Mb3qfENmU7wcAsm5VrND+bU/3eZeI4M9+1C8KaIyhce23Wr7YwVwpSFL0JoVTNHaUyoj/OrWrUu5zIDdDlHFVF5DQ/j6ONw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XAcI4fRGtXgxyYTrpAcpMHaALa969/iT1CA3lScCiXD39zXWBB/bc/+w46mx6HVdCb7UIbSnUraZFjnszAK12FZ4GDMIpJ77B7Y2iKHtspLDq5N+8Xa+U5e3uu+rmv/XB8yKi6ip/LByTJFW2SxYGNUeZ46yotqKXP7Kx70Dq6IBxbJp4wayUqB87fjf85DNTdXNpB4rvsQToujBZeenihJULMpxogfercGuKGUAv4JWCYh3C8HZCAW4EqkvDoJDY+lFY6VMUJce4BQurM4o0GnV9fkcBbZnDArFYNhSNaHZc4ICOnvmJs4MPVgTpljDwBWB6aTHmJdMFMe3xy4I1w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 27 Apr 2026 09:22:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24-Apr-26 3:36 PM, Oleksii Kurochko wrote:
> As domain type is part of common code now there is no any reason
NIT: remove "any" after "no"
> to have architecture-specific set_domain_type() functions so
> it is dropped.
>
> Change the guard around access of kinfo->type to CONFIG_HAS_DOMAIN_TYPE
> for consistency. Also, drop and add some parentheses to be aligned
> with the similar if() below.
>
> x86 with CONFIG_64BIT=y shouldn't use is_{32,64}bit_domain() as
> x86 doesn't have support of CONFIG_HAS_DOMAIN_TYPE. Since x86_32 Xen no
> longer builds, the fallback is currently only relevant for arm32.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
You don't seem to remove enum domain_type type from struct arch_domain which is
now unused. With that removed:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
