[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/4] xen/drivers/char/cadence-uart: fix IRQ registration failure propagation
- To: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 27 Apr 2026 08:35:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OlKRmd4uD1saC1ljr9Cov/tFS8Xr3xnG7DKrbyM7Tos=; b=ebsDLxygCvCy+nXDIn0gtyyesEFnF8HTZg8q5c/J8V8xg8Cpn841P5smO0xfAu8GUyNEPCyiobBySBTp+nhVwJ8rwDJ9mmzdlDoVmjk/1aGDxtxmwVRnnJxtXaJGlKPD98IxMg+kdXselzw4gpZhNNnkNYEVbsz9zVhGUZst8sx5Qw8/UQ62gkgaolR1zHDJycOXjzrJwryjPgQPEbkzsuEw/oi9ryELrZouIRea4qbsFNWzNSPr7grtw/+BIEz7QT/0W8YB4aud3ZmqaNQ40AXkIO3/bL9pjsDLcudZywP5/10QdSeixhU0oOQrLrZcfLotk2atF+aCe7UC5eCrDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nHQJKJRK38bd3GoHzcy7EiudUK3iRKyhdbX06ThD4KWKfoU2buD6FzPtD5zAYCNjrUvJ+Cl50Pf6wjyyRXuBfqnTJ5zAJIw1bTRLsfdaP8YOpPV9XvH4UPW/IwuYb8twZ4XHdkdmuI1XBrRbrOZPcnWMYFMhR61j7x4eDGZoQ+Xwf6rluhRnS7q+qXYwvZPblFq2a8ZPnwqEkTQEA4pW8RpYrpdocKrqkcEQCH2dwPON7FZutZ488vGSMnsOdwZY2yjJ/Wc5l4Mnr0pQs3bVYfE4k0Covbc/LRE9C4HhHNqk+79a1z7CdBtK9o2SAH/C1Y82d5VYv4wfW5oaJ+Tl4w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
- Delivery-date: Mon, 27 Apr 2026 06:35:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23-Apr-26 6:11 PM, Oleksii Moisieiev wrote:
> In cuart_init_postirq(), two code paths could reach the
> interrupt-enable write to IER without a handler being registered:
>
> - When no valid IRQ number was provided (uart->irq <= 0), the original
> positive-condition guard (if uart->irq > 0) skipped the irqaction
> setup but still fell through to the IER write, enabling the receive
> data interrupt with no handler installed.
>
> - When setup_irq() returned an error, only an error message was
> printed and execution continued to the IER write, arming the
> receive hardware interrupt line with no handler to service it. On
> platforms where the GIC receives this asserted line, the result is
> either repeated spurious-interrupt warnings or an unhandled
> interrupt fault.
>
> Restructure cuart_init_postirq() to use early returns in both error
> paths.
>
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
