[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/9] x86/mwait-idle: latch struct idle_cpu contents
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 24 Apr 2026 17:24:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lNhK+c2VMNzcotRRllhYcuFNuh12pdskKP083Umo5d0=; b=C4S/JiaVysDyPl4U0cK9lqzHUMc/9iuXCpHMjmbZ7suipAo2fL0qBeJ15o3PbdlWA98mv3J4cr6ou7y9mnd4/w1IpvFpaLNfMZbkyzrdEgdrDt58MD0X6yDUlSBwn81tICwkaJoMb84r2H0fYsvLsD3UBPeoNJosgMwioPmuNq5Qzx0zKjjZ20mayXN0tyZxMGUDp3ytcKrmO/KUl4Z6suf+pwTINayPHrSBynU6kJBxdRACCTvGzfj4Nl4FkYzD+2RYn7M4WnxqoJ+K+eg8fswmFxQvAB7IC3/Gumr0RacKiRIChuT9q2sZBK20rkUFF48dsKjo1qyH66AVNy0dkQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=me/RWdotcxTGx6nbrG0UwCPqcwvvv7f7An/LfTp7dQyfz6pswcobNjKRpUqS5kVrPQXNQl52K6uPnU95pZ5ZnqipW5QWGsNcsmcdvZvEAjnkTbQO+oBbZR5b0rNKViDjyHZX5Dt00N0r5Mux6348Tia6x/H1HqetJXpd6WC3FlavzSNrvIlSgkemSMST4V1zeeKOXOLQq0yS2f+B8H/l1ZNodRminOBxe+gWCQb+40M8XCVDzbhF2t1XYU27o9xMuKxruAe+ZxBVhlW1dU9OL5lVbcbihUB2Eq7WYwI2VJ2alWZMcxSNAcbgiq9290GgNXgajxAFMIBDtU0efcV98A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 24 Apr 2026 15:24:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 12, 2026 at 05:55:22PM +0100, Jan Beulich wrote:
> Rather than storing a pointer (and needing to keep all struct instances in
> memory post-init), and rather than (like the Linux counterpart has it)
> keeping individual variables, simply copy the respective structure
> instance. By implication, subsequent updates now need doing to the copy.
Shouldn't the aim here be to move the myriad of per-arch cpuidle_state
arrays to the init section, so we can get rid of them after boot?
Overall I wonder whether we would rather attempt to sya in-sync with
what Linux does, simply because it's then easier to pick updates fro
Linux, and less likely to introduce bugs as part of the modification
needs to adapt the Linux code into our fork.
Not saying the change is bad, just wondering whether in general we
would better try to keep the code bases as similar as feasible.
Thanks, Roger.
|
